You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/09/04 22:04:39 UTC

[PR] test(gtf): stop a leaked abort-listener thread in the abort-handler tests [superset]

rusackas opened a new pull request, #43908:
URL: https://github.com/apache/superset/pull/43908

   ### SUMMARY
   
   Two tests in `TestAbortHandlerRegistration` (`tests/unit_tests/tasks/test_handlers.py`) patch `TaskContext.start_abort_polling`, but `on_abort` calls `_start_abort_listener` directly, so the patch is a no-op. A real abort listener starts against the `@patch`ed `current_app` mock, whose `app_context()` yields a coroutine, so every predicate check raises. The thread is never stopped and retries with a 1s backoff for the rest of the pytest session, logging an ERROR each time. Any later test asserting an empty ERROR caplog (the oauth2 lock test in CI run 33834826666 on #43407) fails depending on timing.
   
   This patches the method `on_abort` actually calls, so no listener thread is created. Reproduced locally (the unit job has no random ordering, so the interleaving is deterministic) and confirmed with a thread probe that no `coord-listen-*` thread survives the suite after the change.
   
   Split out of the review of #43407 so it can land on `gaq-to-gtf` like the other steps.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A (test-only)
   
   ### TESTING INSTRUCTIONS
   
   ```
   pytest tests/unit_tests/tasks/test_handlers.py tests/unit_tests/utils/oauth2_tests.py
   ```
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   πŸ€– Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_01MuGcoYy6bWGc9vBTqEB6Aj


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(gtf): stop a leaked abort-listener thread in the abort-handler tests [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #43908:
URL: https://github.com/apache/superset/pull/43908#issuecomment-5547130401

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43908?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 66.30%. Comparing base ([`3915c9b`](https://app.codecov.io/gh/apache/superset/commit/3915c9b8a0592f34d758c0ebcbcce29835b897ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ae8346b`](https://app.codecov.io/gh/apache/superset/commit/ae8346b838c6c6082752ef96d65d057c00dda1b6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (3915c9b) and HEAD (ae8346b). Click for more details.
   > 
   > <details><summary>HEAD has 3 uploads less than BASE</summary>
   >
   >| Flag | BASE (3915c9b) | HEAD (ae8346b) |
   >|------|------|------|
   >|python|6|3|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@               Coverage Diff               @@
   ##           gaq-to-gtf   #43908       +/-   ##
   ===============================================
   - Coverage       79.69%   66.30%   -13.40%     
   ===============================================
     Files            2909     2908        -1     
     Lines          169810   169509      -301     
     Branches        39335    39273       -62     
   ===============================================
   - Hits           135337   112399    -22938     
   - Misses          31950    54801    +22851     
   + Partials         2523     2309      -214     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/43908/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ” | |
   |---|---|---|
   | [hive](https://app.codecov.io/gh/apache/superset/pull/43908/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.76% <ΓΈ> (+0.08%)` | :arrow_up: |
   | [mysql](https://app.codecov.io/gh/apache/superset/pull/43908/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [postgres](https://app.codecov.io/gh/apache/superset/pull/43908/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/43908/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.65% <ΓΈ> (+0.08%)` | :arrow_up: |
   | [python](https://app.codecov.io/gh/apache/superset/pull/43908/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.27% <ΓΈ> (-26.87%)` | :arrow_down: |
   | [sqlite](https://app.codecov.io/gh/apache/superset/pull/43908/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.13% <ΓΈ> (+0.14%)` | :arrow_up: |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/43908/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43908?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(gtf): stop a leaked abort-listener thread in the abort-handler tests [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43908:
URL: https://github.com/apache/superset/pull/43908#issuecomment-5546968249

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(gtf): stop a leaked abort-listener thread in the abort-handler tests [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #43908:
URL: https://github.com/apache/superset/pull/43908#issuecomment-5546984630

   ### <span aria-hidden="true">βœ…</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">πŸ”¨</span> Latest commit | ae8346b838c6c6082752ef96d65d057c00dda1b6 |
   |<span aria-hidden="true">πŸ”</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a9b407773fd6300080b3958 |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-43908--superset-docs-preview.netlify.app](https://deploy-preview-43908--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">πŸ“±</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQzOTA4LS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.edEctrWWJAj6MJuzDtmTDT85pPJjuhx_6WDXnmptGFw)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">πŸ€–</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DctBDoQgDADAv_Qs2SaoqD_wGWCLGBEJ9ODG7N-X21zmhVzuKwssAB24YtMWmv3xfHbxSriKCjZR5FJVZHsyqXhU4cSlBeIc7-9KrYx2dj0aY7SnUSPihE7PwwS_Pw) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-43908--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] test(gtf): stop a leaked abort-listener thread in the abort-handler tests [superset]

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #43908:
URL: https://github.com/apache/superset/pull/43908


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org