You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "SolidWallOfCode (via GitHub)" <gi...@apache.org> on 2023/05/12 20:03:30 UTC

[GitHub] [trafficserver] SolidWallOfCode commented on a diff in pull request #9683: Remove deprecated debug output functions from 19 source files.

SolidWallOfCode commented on code in PR #9683:
URL: https://github.com/apache/trafficserver/pull/9683#discussion_r1192752956


##########
iocore/net/P_NetAccept.h:
##########
@@ -73,7 +73,11 @@ struct NetAcceptAction : public Action, public RefCountObj {
     return Action::operator=(acont);
   }
 
-  ~NetAcceptAction() override { Debug("net_accept", "NetAcceptAction dying"); }
+  ~NetAcceptAction() override
+  {
+    static DbgCtl dbg_ctl{"net_accept"};

Review Comment:
   Are there any concerns about late initialization for this? IIRC the compiler can arrange for `dbg_ctl` to be constructed on first invocation rather than process start.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org