[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting 
URL: https://github.com/apache/skywalking/pull/4462#discussion_r389343319
 
 

 ##########
 File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/ExitTypeSpan.java
 ##########
 @@ -18,8 +18,15 @@
 
 package org.apache.skywalking.apm.agent.core.context.trace;
 
-public interface WithPeerInfo {
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+
+/**
+ * The exit span has some additional behaviours
+ */
+public interface ExitTypeSpan {
     int getPeerId();
 
     String getPeer();
+
+    void inject(ContextCarrier carrier);
 
 Review comment:
   Consider returning `this` for chaining

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services