You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/04/13 15:35:55 UTC

[GitHub] [skywalking] mrproliu commented on issue #4646: Nginx correlation e2e test

mrproliu commented on issue #4646: Nginx correlation e2e test
URL: https://github.com/apache/skywalking/pull/4646#issuecomment-612951702
 
 
   > Could you explain a little about this PR? `correlation` can't be tested in the e2e from my perspective. I noticed you added the correlation header in the nginx, which should/could be read in the java. But there is no way to test this in e2e.
   > 
   > I think this header should only be tests as a part of plugin test. What do you think?
   > FYI @kezhenxu94 , WDYT?
   
   I think the plugin test only tests with the java plugins, I think it cannot cross-language agent test? Do I miss something?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services