You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/27 00:17:44 UTC

[GitHub] [iceberg] felixYyu opened a new pull request, #4879: API:Set index to return value

felixYyu opened a new pull request, #4879:
URL: https://github.com/apache/iceberg/pull/4879

   Closed #4762 
   The override method in IndexByName or IndexParents all return the corresponding variables, but IndexById is not, I think it should also needs to return the corresponding variable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] felixYyu commented on pull request #4879: API:Set index to return value

Posted by GitBox <gi...@apache.org>.
felixYyu commented on PR #4879:
URL: https://github.com/apache/iceberg/pull/4879#issuecomment-1139168635

   cc: @szehon-ho @kbendick  @RussellSpitzer 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue commented on pull request #4879: API:Set index to return value

Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #4879:
URL: https://github.com/apache/iceberg/pull/4879#issuecomment-1140522263

   @felixYyu is this fixing a bug? What is the value of making this change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue closed pull request #4879: API: Return index in IndexById

Posted by GitBox <gi...@apache.org>.
rdblue closed pull request #4879: API: Return index in IndexById
URL: https://github.com/apache/iceberg/pull/4879


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org