[jira] [Commented] (OOZIE-2338) Invalid configuration defined reported for some valid configs

["Rohini Palaniswamy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15504327#comment-15504327 ] 

Rohini Palaniswamy commented on OOZIE-2338:
-------------------------------------------

1) Connection timeout and socket timeout are different. One is for establishing connection and other is for response. Better to keep two different settings for them. I am fine getting rid of SMTP_TIMEOUT and using EMAIL_SMTP_SOCKET_TIMEOUT_MS instead. But can we add equivalent EmailActionExecutor.EMAIL_CONNECTION_SOCKET_TIMEOUT_MS for SMTP_CONNECTION_TIMEOUT and use that in EmailActionExecutor as well for connection timeout.
{code}
-        String smtpConnectTimeout = conf.get(SMTP_CONNECTION_TIMEOUT, SMTP_CONNECTION_TIMEOUT_DEFAULT);
-        String smtpTimeout = conf.get(SMTP_TIMEOUT, SMTP_TIMEOUT_DEFAULT);
+        Integer timeoutMillisInt = ConfigurationService.getInt(EmailActionExecutor.EMAIL_SMTP_SOCKET_TIMEOUT_MS);
{code}
2)  String path = ConfigurationService.get(HCAT_CONFIGURATION).trim();
  Not a fan of this idea as it is hacky. Requires adding dummy values to oozie-default.xml when it does not make sense and handling the dummy value in code. I would rather have them included in a separate list like VERIFY_PREFIX_PROPERTIES_TO_IGNORE and be skipped.

> Invalid configuration defined reported for some valid configs
> -------------------------------------------------------------
>
>                 Key: OOZIE-2338
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2338
>             Project: Oozie
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 4.2.0
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>             Fix For: 4.3.0
>
>         Attachments: OOZIE-2338.001.patch, OOZIE-2338.002.patch
>
>
> OOZIE-1890 moved all default config values from the code and oozie-site into oozie-default; it also added a WARN message on startup when a config is found in oozie-site that's not defined in oozie-default.  
> However, this can produce some false positives.  In particular, we observed these:
> {noformat}
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: SERVER[<redacted>] Invalid configuration defined, [oozie.email.smtp.auth]
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: SERVER[<redacted>] Invalid configuration defined, [oozie.email.smtp.host]
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: SERVER[<redacted>] Invalid configuration defined, [oozie.service.HCatAccessorService.hcat.configuration]
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: SERVER[<redacted>] Invalid configuration defined, [oozie.email.from.address]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: SERVER[<redacted>] Invalid configuration defined, [oozie.service.ProxyUserService.proxyuser.hue.hosts]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: SERVER[<redacted>] Invalid configuration defined, [oozie.service.GroupsService.hadoop.security.group.mapping]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: SERVER[<redacted>] Invalid configuration defined, [oozie.email.smtp.port]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: SERVER[<redacted>] Invalid configuration defined, [oozie.service.ProxyUserService.proxyuser.hue.groups]
> {noformat}
> While harmful, these messages may be concerning or confusing for users.
> Some of these are simply missing from oozie-default (because they have no default value?), while others such as the ProxyUserService configs, will require special handling because the property name can vary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)