You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Michael Stockton (JIRA)" <ji...@apache.org> on 2009/04/12 03:51:15 UTC
[jira] Created: (THRIFT-451) ruby structs use lowercase enum while
modules are capitalized
ruby structs use lowercase enum while modules are capitalized
-------------------------------------------------------------
Key: THRIFT-451
URL: https://issues.apache.org/jira/browse/THRIFT-451
Project: Thrift
Issue Type: Bug
Components: Library (Ruby)
Reporter: Michael Stockton
Assignee: Michael Stockton
Priority: Minor
enum fb_status {
DEAD = 0,
STARTING = 1,
ALIVE = 2,
STOPPING = 3,
STOPPED = 4,
WARNING = 5,
}
The type for fb_status will be created as so:
module Fb_status
end
However, structs will refer to fb_status.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-451) ruby structs use lowercase enum while
modules are capitalized
Posted by "Michael Stockton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Stockton updated THRIFT-451:
------------------------------------
Attachment: thrift-451-v2.patch
> ruby structs use lowercase enum while modules are capitalized
> -------------------------------------------------------------
>
> Key: THRIFT-451
> URL: https://issues.apache.org/jira/browse/THRIFT-451
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Michael Stockton
> Assignee: Michael Stockton
> Priority: Minor
> Attachments: thrift-451-v2.patch, thrift-451.patch
>
>
> enum fb_status {
> DEAD = 0,
> STARTING = 1,
> ALIVE = 2,
> STOPPING = 3,
> STOPPED = 4,
> WARNING = 5,
> }
> The type for fb_status will be created as so:
> module Fb_status
> end
> However, structs will refer to fb_status.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-451) ruby structs use lowercase enum while
modules are capitalized
Posted by "Michael Stockton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Stockton updated THRIFT-451:
------------------------------------
Attachment: thrift-451.patch
Ruby module scopes are capitalized but types are not. This patch updates the full_type_name call so it capitalizes a type before it's appended to the module prefix.
> ruby structs use lowercase enum while modules are capitalized
> -------------------------------------------------------------
>
> Key: THRIFT-451
> URL: https://issues.apache.org/jira/browse/THRIFT-451
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Michael Stockton
> Assignee: Michael Stockton
> Priority: Minor
> Attachments: thrift-451.patch
>
>
> enum fb_status {
> DEAD = 0,
> STARTING = 1,
> ALIVE = 2,
> STOPPING = 3,
> STOPPED = 4,
> WARNING = 5,
> }
> The type for fb_status will be created as so:
> module Fb_status
> end
> However, structs will refer to fb_status.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-451) ruby structs use lowercase enum while
modules are capitalized
Posted by "Michael Stockton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Stockton updated THRIFT-451:
------------------------------------
Component/s: (was: Library (Ruby))
Compiler (Ruby)
Patch Info: [Patch Available]
> ruby structs use lowercase enum while modules are capitalized
> -------------------------------------------------------------
>
> Key: THRIFT-451
> URL: https://issues.apache.org/jira/browse/THRIFT-451
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Reporter: Michael Stockton
> Assignee: Michael Stockton
> Priority: Minor
> Attachments: thrift-451-v2.patch, thrift-451.patch
>
>
> enum fb_status {
> DEAD = 0,
> STARTING = 1,
> ALIVE = 2,
> STOPPING = 3,
> STOPPED = 4,
> WARNING = 5,
> }
> The type for fb_status will be created as so:
> module Fb_status
> end
> However, structs will refer to fb_status.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-451) ruby structs use lowercase enum while
modules are capitalized
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-451.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.1
Committed. Thanks for the patch!
> ruby structs use lowercase enum while modules are capitalized
> -------------------------------------------------------------
>
> Key: THRIFT-451
> URL: https://issues.apache.org/jira/browse/THRIFT-451
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Reporter: Michael Stockton
> Assignee: Michael Stockton
> Priority: Minor
> Fix For: 0.1
>
> Attachments: thrift-451-v2.patch, thrift-451.patch
>
>
> enum fb_status {
> DEAD = 0,
> STARTING = 1,
> ALIVE = 2,
> STOPPING = 3,
> STOPPED = 4,
> WARNING = 5,
> }
> The type for fb_status will be created as so:
> module Fb_status
> end
> However, structs will refer to fb_status.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.