You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/21 05:58:32 UTC

[GitHub] [incubator-superset] rusackas commented on a change in pull request #11340: feat: adding feature flags to escape/hide html in markdown

rusackas commented on a change in pull request #11340:
URL: https://github.com/apache/incubator-superset/pull/11340#discussion_r509008038



##########
File path: superset/config.py
##########
@@ -308,6 +308,8 @@ def _try_json_readsha(  # pylint: disable=unused-argument
     "TAGGING_SYSTEM": False,
     "SQLLAB_BACKEND_PERSISTENCE": False,
     "LISTVIEWS_DEFAULT_CARD_VIEW": False,
+    "DISPLAY_MARKDOWN_HTML": True,
+    "ESCAPE_MARKDOWN_HTML": False,

Review comment:
       The default settings in this PR mimic the current default behavior, so the feature shouldn't require any action when updating.
   
   That said, the comments to seem valuable. I'll add 'em!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org