You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2010/09/24 07:18:32 UTC
[jira] Created: (WHIRR-104) print available services in cli help
string
print available services in cli help string
-------------------------------------------
Key: WHIRR-104
URL: https://issues.apache.org/jira/browse/WHIRR-104
Project: Whirr
Issue Type: Improvement
Components: core
Affects Versions: 0.1.0
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Minor
Fix For: 0.2.0
Attachments: WHIRR-104.patch
It would be useful to be able to see available services when running cli.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-104) print available services in cli help
string
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914524#action_12914524 ]
Tom White commented on WHIRR-104:
---------------------------------
This looks good. A couple of nits:
* You could just return a SortedSet in ServiceFactory ({{Sets.newTreeSet()}}). I found it slightly odd that list() returned a set - perhaps call it getServiceNames()?
* Indentation should be two spaces.
> print available services in cli help string
> -------------------------------------------
>
> Key: WHIRR-104
> URL: https://issues.apache.org/jira/browse/WHIRR-104
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.1.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: WHIRR-104.patch
>
>
> It would be useful to be able to see available services when running cli.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-104) print available services in cli help
string
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated WHIRR-104:
-------------------------------
Attachment: WHIRR-104.patch
updated to fix merge conflict
> print available services in cli help string
> -------------------------------------------
>
> Key: WHIRR-104
> URL: https://issues.apache.org/jira/browse/WHIRR-104
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.1.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: WHIRR-104.patch, WHIRR-104.patch, WHIRR-104.patch
>
>
> It would be useful to be able to see available services when running cli.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-104) print available services in cli help
string
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated WHIRR-104:
-------------------------------
Attachment: WHIRR-104.patch
addressed the formatting.
I renamed the method to something more appropriate. However I don't think making the method return a sorted set is very good idea - too tight a coupling. it should really just return a collection of service names and let the called decide if it needs it sorted. I did use a treemap though on the caller side ( good idea, cleaned it up a bit).
> print available services in cli help string
> -------------------------------------------
>
> Key: WHIRR-104
> URL: https://issues.apache.org/jira/browse/WHIRR-104
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.1.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: WHIRR-104.patch, WHIRR-104.patch
>
>
> It would be useful to be able to see available services when running cli.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-104) print available services in cli help
string
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated WHIRR-104:
-------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
> print available services in cli help string
> -------------------------------------------
>
> Key: WHIRR-104
> URL: https://issues.apache.org/jira/browse/WHIRR-104
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.1.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: WHIRR-104.patch, WHIRR-104.patch, WHIRR-104.patch
>
>
> It would be useful to be able to see available services when running cli.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-104) print available services in cli help
string
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated WHIRR-104:
-------------------------------
Status: Open (was: Patch Available)
> print available services in cli help string
> -------------------------------------------
>
> Key: WHIRR-104
> URL: https://issues.apache.org/jira/browse/WHIRR-104
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.1.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: WHIRR-104.patch, WHIRR-104.patch
>
>
> It would be useful to be able to see available services when running cli.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-104) print available services in cli help
string
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated WHIRR-104:
-------------------------------
Status: Patch Available (was: Open)
> print available services in cli help string
> -------------------------------------------
>
> Key: WHIRR-104
> URL: https://issues.apache.org/jira/browse/WHIRR-104
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.1.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: WHIRR-104.patch, WHIRR-104.patch
>
>
> It would be useful to be able to see available services when running cli.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-104) print available services in cli help
string
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated WHIRR-104:
-------------------------------
Attachment: WHIRR-104.patch
> print available services in cli help string
> -------------------------------------------
>
> Key: WHIRR-104
> URL: https://issues.apache.org/jira/browse/WHIRR-104
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.1.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: WHIRR-104.patch
>
>
> It would be useful to be able to see available services when running cli.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-104) print available services in cli help
string
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915807#action_12915807 ]
Tom White commented on WHIRR-104:
---------------------------------
+1
> print available services in cli help string
> -------------------------------------------
>
> Key: WHIRR-104
> URL: https://issues.apache.org/jira/browse/WHIRR-104
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.1.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: WHIRR-104.patch, WHIRR-104.patch
>
>
> It would be useful to be able to see available services when running cli.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-104) print available services in cli help
string
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated WHIRR-104:
-------------------------------
Status: Patch Available (was: Open)
> print available services in cli help string
> -------------------------------------------
>
> Key: WHIRR-104
> URL: https://issues.apache.org/jira/browse/WHIRR-104
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.1.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: WHIRR-104.patch
>
>
> It would be useful to be able to see available services when running cli.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.