You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/09 08:10:04 UTC
[jira] [Commented] (FLINK-6486) Pass RowTypeInfo to CodeGenerator
instead of CRowTypeInfo
[ https://issues.apache.org/jira/browse/FLINK-6486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002252#comment-16002252 ]
ASF GitHub Bot commented on FLINK-6486:
---------------------------------------
GitHub user hequn8128 opened a pull request:
https://github.com/apache/flink/pull/3850
[FLINK-6486] [table] (bugfix) Pass RowTypeInfo to CodeGenerator instead of CRowTypeInfo
For now CodeGenerator only processes Row type, so we should pass RowTypeInfo to CodeGenerator instead of CRowTypeInfo. We can find these bugs in DataStreamGroupAggregate, DataStreamGroupWindowAggregate and DataStreamOverAggregate. These bugs will bring no error to the current flink because no code will make use of the error input type, however we should correct it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hequn8128/flink bugfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3850.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3850
----
commit 75d668eb157e0ed90132976dcc96c167176810d1
Author: Hequn Cheng <ch...@gmail.com>
Date: 2017-05-08T12:55:51Z
[FLINK-6486] [table] (bugfix) Pass RowTypeInfo to CodeGenerator instead of CRowTypeInfo
----
> Pass RowTypeInfo to CodeGenerator instead of CRowTypeInfo
> ----------------------------------------------------------
>
> Key: FLINK-6486
> URL: https://issues.apache.org/jira/browse/FLINK-6486
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: Hequn Cheng
> Assignee: Hequn Cheng
>
> For now CodeGenerator only processes Row type, so we should pass RowTypeInfo to CodeGenerator instead of CRowTypeInfo. We can find these bugs in DataStreamGroupAggregate, DataStreamGroupWindowAggregate and DataStreamOverAggregate. These bugs will bring no error to the current flink because no code will make use of the error input type, however we should correct it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)