You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/06/08 20:18:40 UTC
[GitHub] [superset] justinpark opened a new pull request, #24329: feat(sqllab): add shortcut for run current sql
justinpark opened a new pull request, #24329:
URL: https://github.com/apache/superset/pull/24329
### SUMMARY
The manual selection of the current query is time-consuming. (Longer the query more time it takes to select manually)
This commit creates a new shortcut(`ctrl + shift + enter`) which automatically detects and selects the range of the current query and then run the selection in order to reduce the manual selection work.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
https://github.com/apache/superset/assets/1392866/d146c9a5-5819-4fe2-af22-6281f3bb0de6
Before:
https://github.com/apache/superset/assets/1392866/45f22a20-32b3-4eab-b075-95bf4e108df6
### TESTING INSTRUCTIONS
Hit "Ctrl+Shift+Enter" on sql editor
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1626345699
cc: @cploonker @michael-s-molina @EugeneTorap
As suggested, I updated the selection back to the current cursor position.
https://github.com/apache/superset/assets/1392866/197e0ca1-b718-484b-8d51-60fcf1fa5d8e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1583389843
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1583296102
This is awesome! I'll review it tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1681318612
> This is awesome! I'll review it tomorrow.
Agreed, this has been long overdue, thanks for this work @justinpark ! ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cploonker commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "cploonker (via GitHub)" <gi...@apache.org>.
cploonker commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1627485516
> cc: @cploonker @michael-s-molina @EugeneTorap
>
> As suggested, I updated the selection back to the current cursor position.
>
> without.selection.mov
ooohhh nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1591036652
> Is it possible to send the delimited query for execution without actually selecting the query in the UI?
I think this is a great suggestion from an usability perspective. It's quite common to edit the statement after a failed query. That's actually the default behavior of many database tools. Here's an example of [DBeaver](https://dbeaver.io/):
https://github.com/apache/superset/assets/70410625/8dd4c68d-eff5-4ce6-92ca-cf4596fcb9c5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1631318674
@justinpark Merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1584941196
Should we ignore comments?
https://github.com/apache/superset/assets/70410625/0daa6018-338c-48cb-9d10-02dc7cbfb4a1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1588019781
> Should we ignore comments?
>
> Screen.Recording.2023-06-09.at.14.47.42.mov
As we faced the regression of handling comments in FE, ignoring comments makes more complex and can be an issue in some edge cases. I'd rather make simple (including comments) to make features functional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cploonker commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "cploonker (via GitHub)" <gi...@apache.org>.
cploonker commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1599430803
Can we merge this change please.
We can always iterate on how ctrl + shift + enter works.
For the most part the end user experience will remain the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cploonker commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "cploonker (via GitHub)" <gi...@apache.org>.
cploonker commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1590250660
Is it possible to send the delimited query for execution without actually selecting the query in the UI?
Can we NOT skip this step off selecting it in the UI?
I don't have a demo to play with, but I was thinking that the selection will actually move my cursor and if I need to further edit then I still need to use the mouse to go back to the location of edit.
If not i guess this can be a stepping stone to end goal some day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1583556529
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1583397532
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24329?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24329](https://app.codecov.io/gh/apache/superset/pull/24329?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (676ab0d) into [master](https://app.codecov.io/gh/apache/superset/commit/c4242a36572f0468766bad5e645f532d585af642?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c4242a3) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 676ab0d differs from pull request most recent head c1d882e. Consider uploading reports for the commit c1d882e to get more accurate results
```diff
@@ Coverage Diff @@
## master #24329 +/- ##
==========================================
- Coverage 69.08% 69.06% -0.02%
==========================================
Files 1905 1905
Lines 74848 74869 +21
Branches 8108 8115 +7
==========================================
Hits 51705 51705
- Misses 21031 21052 +21
Partials 2112 2112
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `55.58% <0.00%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...frontend/src/SqlLab/components/SqlEditor/index.jsx](https://app.codecov.io/gh/apache/superset/pull/24329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci9pbmRleC5qc3g=) | `53.53% <0.00%> (-6.36%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1625693360
@justinpark Thanks for this nice PR!
@michael-s-molina Can rerun the cancelled CI test and merge the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1584398732
@michael-s-molina Container image not yet published for this PR. Please try again when build is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1584398753
@michael-s-molina Ephemeral environment creation failed. Please check the Actions logs for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1588016768
> If the cursor is at the end of the line, it will jump to the next statement.
>
> Screen.Recording.2023-06-09.at.14.44.03.mov
As Chandraprakash mentioned, this is intended. If the cursor is the next to the semi column, it will jump to the next statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1583391254
@michael-s-molina Ephemeral environment creation failed. Please check the Actions logs for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1584937679
If the cursor is at the end of the line, it will jump to the next statement.
https://github.com/apache/superset/assets/70410625/e3f00516-6efe-49d4-be32-fafe278fe570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1584399919
@justinpark Ephemeral environments are not working anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1584397955
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1630202706
Hi @rusackas @kgabryje! Can we merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1600796455
> Can we please merge this change.
> We can always iterate on how ctrl + shift + enter works.
> For the most part the end user experience will remain the same
The iterative approach makes sense given that the current behavior already offers a valuable feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark merged pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark merged PR #24329:
URL: https://github.com/apache/superset/pull/24329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cploonker commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "cploonker (via GitHub)" <gi...@apache.org>.
cploonker commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1591782949
We can try to pass an additional parameter into `runQueryFromSqlEditor` e.g. currentQuery=true with default value as false. And then move the calc to find the query inside that function.
https://github.com/apache/superset/blob/c1d882e9153624046a450257a6e19e36a1f96e9d/superset-frontend/src/SqlLab/actions/sqlLab.js#L390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1583391220
@michael-s-molina Container image not yet published for this PR. Please try again when build is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1583556751
@justinpark Ephemeral environment creation is currently limited to committers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cploonker commented on pull request #24329: feat(sqllab): add shortcut for run current sql
Posted by "cploonker (via GitHub)" <gi...@apache.org>.
cploonker commented on PR #24329:
URL: https://github.com/apache/superset/pull/24329#issuecomment-1585224236
To me it should be any query delimited by semi-colon OR (start/end of file) around the cursor should be picked.
If the cursor is just after the semicolon, next query should be picked.
If I am editing a specific query my cursor is likely going to be inside that query,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org