You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/08/26 21:00:32 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #5032: [website]Support multi version for swagger

merlimat commented on a change in pull request #5032: [website]Support multi version for swagger
URL: https://github.com/apache/pulsar/pull/5032#discussion_r317796702
 
 

 ##########
 File path: src/gen-swagger.sh
 ##########
 @@ -22,10 +22,43 @@ PULSAR_PATH=$(git rev-parse --show-toplevel)
 
 cd $PULSAR_PATH
 
-echo "Generating swagger json file ..."
+git checkout v2.3.0
 
 Review comment:
   This will require to update this file for each release which is not ideal. We could get the list of versions from `versions.json` though the maven install might take a while to complete.
   
   Another option would be to just build the latest version and make sure we add the version tag, so that we just build 1 version (since the older docs will not change).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services