You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by terbolous <gi...@git.apache.org> on 2015/08/27 09:15:31 UTC
[GitHub] cloudstack-www pull request: Python script to generate pmc and com...
GitHub user terbolous opened a pull request:
https://github.com/apache/cloudstack-www/pull/14
Python script to generate pmc and commiter list
Made a small tool to create pmc and committer list by parsing the JSON
files on projects.apache.org.
This is accessible by anyone and does not require any ASF privileges.
Usage: python makewholist.py
Only dependencies are json, urllib and sys, which should be included by
default on most systems.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/terbolous/cloudstack-www master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack-www/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit c264a70f094ee419d224e362bdaf26f9603da33b
Author: Erik Weber <te...@gmail.com>
Date: 2015-08-27T07:12:01Z
Python script to generate pmc and commiter list
Made a small tool to create pmc and committer list by parsing the JSON
files on projects.apache.org.
This is accessible by anyone and does not require any ASF privileges.
Usage: python makewholist.py
Only dependencies are json, urllib and sys, which should be included by
default on most systems.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-www pull request: Python script to generate pmc and com...
Posted by sedukull <gi...@git.apache.org>.
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack-www/pull/14#discussion_r38068341
--- Diff: makewholist.py ---
@@ -0,0 +1,68 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import json
+import sys
+import urllib
+
+groups_url = "https://projects.apache.org/json/foundation/groups.json"
+names_url = "https://projects.apache.org/json/foundation/people_name.json"
+
+names = {} # Placeholder for names parsed in getNames()
+groups = {} # Placeholder for groups parsed in getCommittersAndPMC()
+
+def getCommittersAndPMC():
+ global groups
+ try:
+ response = urllib.urlopen(groups_url)
--- End diff --
mention global for groups_url as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-www pull request: Python script to generate pmc and com...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack-www/pull/14#issuecomment-135374394
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-www pull request: Python script to generate pmc and com...
Posted by sedukull <gi...@git.apache.org>.
Github user sedukull commented on the pull request:
https://github.com/apache/cloudstack-www/pull/14#issuecomment-135375292
Was looking to be consistent when referring to global variables, but otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-www pull request: Python script to generate pmc and com...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack-www/pull/14#issuecomment-135368790
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-www pull request: Python script to generate pmc and com...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack-www/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-www pull request: Python script to generate pmc and com...
Posted by terbolous <gi...@git.apache.org>.
Github user terbolous commented on a diff in the pull request:
https://github.com/apache/cloudstack-www/pull/14#discussion_r38068791
--- Diff: makewholist.py ---
@@ -0,0 +1,68 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import json
+import sys
+import urllib
+
+groups_url = "https://projects.apache.org/json/foundation/groups.json"
+names_url = "https://projects.apache.org/json/foundation/people_name.json"
+
+names = {} # Placeholder for names parsed in getNames()
+groups = {} # Placeholder for groups parsed in getCommittersAndPMC()
+
+def getCommittersAndPMC():
+ global groups
+ try:
+ response = urllib.urlopen(groups_url)
--- End diff --
It is not really necessary to use global to read variables, is there a reason you want it to be?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-www pull request: Python script to generate pmc and com...
Posted by sedukull <gi...@git.apache.org>.
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack-www/pull/14#discussion_r38068366
--- Diff: makewholist.py ---
@@ -0,0 +1,68 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import json
+import sys
+import urllib
+
+groups_url = "https://projects.apache.org/json/foundation/groups.json"
+names_url = "https://projects.apache.org/json/foundation/people_name.json"
+
+names = {} # Placeholder for names parsed in getNames()
+groups = {} # Placeholder for groups parsed in getCommittersAndPMC()
+
+def getCommittersAndPMC():
+ global groups
+ try:
+ response = urllib.urlopen(groups_url)
+ groups = json.loads(response.read())
+ except Exception, e:
+ print "Error during groups JSON download or parsing: %s" % e.message
+
+def getNames():
+ global names
+ try:
+ response = urllib.urlopen(names_url)
--- End diff --
use global names_url here as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-www pull request: Python script to generate pmc and com...
Posted by terbolous <gi...@git.apache.org>.
Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack-www/pull/14#issuecomment-135317900
As mentioned in #13, I went ahead and made a script that does not rely on any ASF privileges.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---