You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Garrett Rooney <ro...@electricjellyfish.net> on 2005/10/26 17:08:16 UTC
Re: svn commit: r17034 - in trunk/subversion: mod_authz_svn mod_dav_svn
On 10/26/05, kfogel@tigris.org <kf...@tigris.org> wrote:
> - svn_error_clear (svn_cmdline_fprintf (stream, err->pool,
> - _("%swarning: %s\n"),
> - prefix, err->message));
> + svn_error_clear (svn_cmdline_fprintf
> + (stream, err->pool,
> + _("%swarning: %s\n"),
> + prefix, (err->message ? err->message :
> + "[no further information available]")));
Shouldn't the "[no further information available]" part of the error
message be wrapped in _() so it can be translated?
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r17034 - in trunk/subversion: mod_authz_svn mod_dav_svn
Posted by kf...@collab.net.
Garrett Rooney <ro...@electricjellyfish.net> writes:
> On 10/26/05, kfogel@tigris.org <kf...@tigris.org> wrote:
>
> > - svn_error_clear (svn_cmdline_fprintf (stream, err->pool,
> > - _("%swarning: %s\n"),
> > - prefix, err->message));
> > + svn_error_clear (svn_cmdline_fprintf
> > + (stream, err->pool,
> > + _("%swarning: %s\n"),
> > + prefix, (err->message ? err->message :
> > + "[no further information available]")));
>
> Shouldn't the "[no further information available]" part of the error
> message be wrapped in _() so it can be translated?
Duh!
Thank you, yes, I will fix.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r17034 - in trunk/subversion: mod_authz_svn mod_dav_svn
Posted by Julian Foad <ju...@btopenworld.com>.
Garrett Rooney wrote:
> On 10/26/05, kfogel@tigris.org <kf...@tigris.org> wrote:
>
>>- svn_error_clear (svn_cmdline_fprintf (stream, err->pool,
>>- _("%swarning: %s\n"),
>>- prefix, err->message));
>>+ svn_error_clear (svn_cmdline_fprintf
>>+ (stream, err->pool,
>>+ _("%swarning: %s\n"),
>>+ prefix, (err->message ? err->message :
>>+ "[no further information available]")));
>
> Shouldn't the "[no further information available]" part of the error
> message be wrapped in _() so it can be translated?
Eww! Is is _really_ more useful to print "[no further information available]"
than just to print no further information? I'm trying to think of a situation
where somebody would be better off, and failing to do so. Help me!
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org