[GitHub] [trafficserver] bneradt commented on a diff in pull request #8818: Expose setting some HTTP/2 tunables via sni.yaml

[GitBox <gi...@apache.org>]

bneradt commented on code in PR #8818:
URL: https://github.com/apache/trafficserver/pull/8818#discussion_r869342728


##########
iocore/net/P_SNIActionPerformer.h:
##########
@@ -98,6 +98,30 @@ class ControlH2 : public ActionItem
   bool enable_h2 = false;
 };
 
+class HTTP2BufferWaterMark : public ActionItem
+{
+public:
+  HTTP2BufferWaterMark(int value) : value(value) {}
+  ~HTTP2BufferWaterMark() override {}
+
+  int
+  SNIAction(TLSSNISupport *snis, const Context &ctx) const override
+  {
+    if (!value) {

Review Comment:
   For non-bools, I suggest explicit compares:
   
   ```
   if (value == 0) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org