You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@reef.apache.org by "Anupam (JIRA)" <ji...@apache.org> on 2016/02/10 21:51:18 UTC

[jira] [Created] (REEF-1203) Minimize the use of Thread.Sleep in REEF tests

Anupam created REEF-1203:
----------------------------

             Summary: Minimize the use of Thread.Sleep in REEF tests
                 Key: REEF-1203
                 URL: https://issues.apache.org/jira/browse/REEF-1203
             Project: REEF
          Issue Type: Bug
            Reporter: Anupam
            Priority: Minor


Thread.Sleep is not a good pattern in tests and unit tests.
 * Tests are slower than required.
 * Tests behaves differently in different environments.
 * Benign changes can lead to test failure as the expected timeout is now longer.

Following are possible locations where Thread.Sleep usage needs to be inspected.

lang\cs\Org.Apache.REEF.Tang.Examples\Timer.cs(44):
lang\cs\Org.Apache.REEF.Wake.Tests\ClockTest.cs(43):
lang\cs\Org.Apache.REEF.Wake.Tests\ClockTest.cs(67):
lang\cs\Org.Apache.REEF.Wake.Tests\ClockTest.cs(71):
lang\cs\Org.Apache.REEF.Wake.Tests\ClockTest.cs(75):
lang\cs\Org.Apache.REEF.Wake.Tests\ClockTest.cs(80):
lang\cs\Org.Apache.REEF.Wake.Tests\ClockTest.cs(99):
lang\cs\Org.Apache.REEF.Wake.Tests\ClockTest.cs(120):
lang\cs\Org.Apache.REEF.Common\Runtime\Evaluator\HeartBeatManager.cs(361):
lang\cs\Org.Apache.REEF.Network\Group\Task\Impl\OperatorTopology.cs(520): 
lang\cs\Org.Apache.REEF.Client\Common\JobSubmissionResult.cs(231):   
lang\cs\Org.Apache.REEF.Client\Common\JobSubmissionResult.cs(266):
lang\cs\Org.Apache.REEF.Client\Local\LocalJobSubmissionResult.cs(58):
lang\cs\Org.Apache.REEF.Tests\Functional\Messaging\MessageTask.cs(62):
lang\cs\Org.Apache.REEF.Tests\Functional\ReefFunctionalTest.cs(120):
lang\cs\Org.Apache.REEF.Tests\Functional\ReefFunctionalTest.cs(156):
lang\cs\Org.Apache.REEF.Tests\Functional\ReefFunctionalTest.cs(189):
lang\cs\Org.Apache.REEF.Tests\Functional\RuntimeName\RuntimeNameTask.cs(40):
lang\cs\Org.Apache.REEF.Examples\Tasks\StreamingTasks\StreamTask1.cs(43):
lang\cs\Org.Apache.REEF.Network.Tests\NamingService\NameServerTests.cs(128):
lang\cs\Org.Apache.REEF.Network.Tests\NamingService\NameServerTests.cs(252):



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)