[jira] [Comment Edited] (MESOS-8377) RecoverTest.CatchupTruncated is flaky.

["Ilya Pronin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310511#comment-16310511 ] 

Ilya Pronin edited comment on MESOS-8377 at 1/4/18 12:14 AM:
-------------------------------------------------------------

Review request: https://reviews.apache.org/r/64938/

I couldn't reproduce the issue on my machine with {{--gtest_repeat=1000 --gtest_break_on_failure=1}}, but I suspect that it has something to do with the fact the test uses {{Shared<Replica>}} which probably can still be retained by "managed" {{CatchupProcess}} at the moment when I [try to recreate the replica| https://github.com/apache/mesos/blob/master/src/tests/log_tests.cpp#L2096]. Because of that the DB can not be closed and LevelDB complaints that the process still holds the DB lock. I've added the code to make sure that the test code is the only owner of {{replica3}} before proceeding to recreate it.


was (Author: ipronin):
Review request: https://reviews.apache.org/r/64938/

I couldn't reproduce the issue on my machine with `--gtest_repeat=1000 --gtest_break_on_failure=1`, but I suspect that it has something to do with the fact the test uses {{Shared<Replica>}} which probably can still be retained by "managed" {{CatchupProcess}} at the moment when I [try to recreate the replica| https://github.com/apache/mesos/blob/master/src/tests/log_tests.cpp#L2096]. Because of that the DB can not be closed and LevelDB complaints that the process still holds the DB lock. I've added the code to make sure that the test code is the only owner of {{replica3}} before proceeding to recreate it.

> RecoverTest.CatchupTruncated is flaky.
> --------------------------------------
>
>                 Key: MESOS-8377
>                 URL: https://issues.apache.org/jira/browse/MESOS-8377
>             Project: Mesos
>          Issue Type: Bug
>          Components: replicated log
>            Reporter: Alexander Rukletsov
>            Assignee: Ilya Pronin
>              Labels: flaky-test
>         Attachments: CatchupTruncated-badrun.txt, RecoverTest.CatchupTruncated-badrun2.txt
>
>
> Observing regularly in our CI. Logs attached.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)