You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/06 03:52:41 UTC
[GitHub] [flink] curcur opened a new pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
curcur opened a new pull request #14567:
URL: https://github.com/apache/flink/pull/14567
…ppropriate package
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
}, {
"hash" : "fd814d3852fa018df06a8854b65d83493338b28c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681",
"triggerID" : "fd814d3852fa018df06a8854b65d83493338b28c",
"triggerType" : "PUSH"
}, {
"hash" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688",
"triggerID" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"triggerType" : "PUSH"
}, {
"hash" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fd814d3852fa018df06a8854b65d83493338b28c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681)
* 9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688)
* d4acadd0437adb13bffc3b74e76fa09942ab9422 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
}, {
"hash" : "fd814d3852fa018df06a8854b65d83493338b28c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681",
"triggerID" : "fd814d3852fa018df06a8854b65d83493338b28c",
"triggerType" : "PUSH"
}, {
"hash" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a0bb9719e9f50891b73c316c03366367904c7d39 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679)
* fd814d3852fa018df06a8854b65d83493338b28c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681)
* 9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #14567:
URL: https://github.com/apache/flink/pull/14567#discussion_r555008866
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -26,7 +26,14 @@
import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup;
import org.apache.flink.streaming.api.graph.StreamConfig;
import org.apache.flink.streaming.api.operators.MailboxExecutor;
-import org.apache.flink.streaming.runtime.tasks.SubtaskCheckpointCoordinator;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlignedController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlternatingController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.CheckpointBarrierBehaviourController;
Review comment:
"CheckpointedInputGate" is overall an input gate (but just a different type of input gate), that's why I left it in .....runtime.io
`InputProcessorUtil` is mostly createXXXCheckpointedInputGate, that's why I left it with "CheckpointedInputGate"
`UpstreamRecoveryTracker` is channel recovery-related, and that's why I put within .....runtime.io as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
curcur commented on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-759189724
My local azure green
https://dev.azure.com/mymeiyuan/Flink/_build/results?buildId=163&view=results
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
}, {
"hash" : "fd814d3852fa018df06a8854b65d83493338b28c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681",
"triggerID" : "fd814d3852fa018df06a8854b65d83493338b28c",
"triggerType" : "PUSH"
}, {
"hash" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688",
"triggerID" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"triggerType" : "PUSH"
}, {
"hash" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11690",
"triggerID" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"triggerType" : "PUSH"
}, {
"hash" : "27095134441ec13971f36c873bca2a03d904cf36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11700",
"triggerID" : "27095134441ec13971f36c873bca2a03d904cf36",
"triggerType" : "PUSH"
}, {
"hash" : "745ac6c55e31eecc4519c5590f387497ef50eaf9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11876",
"triggerID" : "745ac6c55e31eecc4519c5590f387497ef50eaf9",
"triggerType" : "PUSH"
}, {
"hash" : "4c81f998b5a359dfae299c69d18c93e064c47538",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4c81f998b5a359dfae299c69d18c93e064c47538",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 745ac6c55e31eecc4519c5590f387497ef50eaf9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11876)
* 4c81f998b5a359dfae299c69d18c93e064c47538 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755061754
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a0bb9719e9f50891b73c316c03366367904c7d39 (Wed Jan 06 03:55:12 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20453).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #14567:
URL: https://github.com/apache/flink/pull/14567
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
curcur commented on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-758415804
Based on discussion offline, and, because everyone has some parts of insists :-), we decided to
1. Leave `SubtaskCheckpointCoordinator(Impl)` related as it is.
2. move checkpoint-io related to `org.apache.flink.streaming.runtime.io.checkpointing`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
}, {
"hash" : "fd814d3852fa018df06a8854b65d83493338b28c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681",
"triggerID" : "fd814d3852fa018df06a8854b65d83493338b28c",
"triggerType" : "PUSH"
}, {
"hash" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688",
"triggerID" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"triggerType" : "PUSH"
}, {
"hash" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11690",
"triggerID" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688)
* d4acadd0437adb13bffc3b74e76fa09942ab9422 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11690)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
}, {
"hash" : "fd814d3852fa018df06a8854b65d83493338b28c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681",
"triggerID" : "fd814d3852fa018df06a8854b65d83493338b28c",
"triggerType" : "PUSH"
}, {
"hash" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688",
"triggerID" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"triggerType" : "PUSH"
}, {
"hash" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11690",
"triggerID" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"triggerType" : "PUSH"
}, {
"hash" : "27095134441ec13971f36c873bca2a03d904cf36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11700",
"triggerID" : "27095134441ec13971f36c873bca2a03d904cf36",
"triggerType" : "PUSH"
}, {
"hash" : "745ac6c55e31eecc4519c5590f387497ef50eaf9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11876",
"triggerID" : "745ac6c55e31eecc4519c5590f387497ef50eaf9",
"triggerType" : "PUSH"
}, {
"hash" : "4c81f998b5a359dfae299c69d18c93e064c47538",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11903",
"triggerID" : "4c81f998b5a359dfae299c69d18c93e064c47538",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4c81f998b5a359dfae299c69d18c93e064c47538 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11903)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a0bb9719e9f50891b73c316c03366367904c7d39 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
}, {
"hash" : "fd814d3852fa018df06a8854b65d83493338b28c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681",
"triggerID" : "fd814d3852fa018df06a8854b65d83493338b28c",
"triggerType" : "PUSH"
}, {
"hash" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688",
"triggerID" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"triggerType" : "PUSH"
}, {
"hash" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11690",
"triggerID" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"triggerType" : "PUSH"
}, {
"hash" : "27095134441ec13971f36c873bca2a03d904cf36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11700",
"triggerID" : "27095134441ec13971f36c873bca2a03d904cf36",
"triggerType" : "PUSH"
}, {
"hash" : "745ac6c55e31eecc4519c5590f387497ef50eaf9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11876",
"triggerID" : "745ac6c55e31eecc4519c5590f387497ef50eaf9",
"triggerType" : "PUSH"
}, {
"hash" : "4c81f998b5a359dfae299c69d18c93e064c47538",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11903",
"triggerID" : "4c81f998b5a359dfae299c69d18c93e064c47538",
"triggerType" : "PUSH"
}, {
"hash" : "870ee4ebdef1d0d111946c583259c8ff6149f3bd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11911",
"triggerID" : "870ee4ebdef1d0d111946c583259c8ff6149f3bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4c81f998b5a359dfae299c69d18c93e064c47538 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11903)
* 870ee4ebdef1d0d111946c583259c8ff6149f3bd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11911)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #14567:
URL: https://github.com/apache/flink/pull/14567#discussion_r555008866
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -26,7 +26,14 @@
import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup;
import org.apache.flink.streaming.api.graph.StreamConfig;
import org.apache.flink.streaming.api.operators.MailboxExecutor;
-import org.apache.flink.streaming.runtime.tasks.SubtaskCheckpointCoordinator;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlignedController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlternatingController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.CheckpointBarrierBehaviourController;
Review comment:
I am fine with either way, but the following explains some of the considerations why they are put in the current way.
======
`CheckpointedInputGate` is overall an input gate (but just a different type of input gate), that's why I left it in .....runtime.io
`InputProcessorUtil` is mostly createXXXCheckpointedInputGate, that's why I left it with "CheckpointedInputGate"
`UpstreamRecoveryTracker` is channel recovery-related, and that's why I put within .....runtime.io as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755061754
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 870ee4ebdef1d0d111946c583259c8ff6149f3bd (Fri May 28 07:06:25 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
}, {
"hash" : "fd814d3852fa018df06a8854b65d83493338b28c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fd814d3852fa018df06a8854b65d83493338b28c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a0bb9719e9f50891b73c316c03366367904c7d39 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679)
* fd814d3852fa018df06a8854b65d83493338b28c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
}, {
"hash" : "fd814d3852fa018df06a8854b65d83493338b28c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681",
"triggerID" : "fd814d3852fa018df06a8854b65d83493338b28c",
"triggerType" : "PUSH"
}, {
"hash" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688",
"triggerID" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"triggerType" : "PUSH"
}, {
"hash" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11690",
"triggerID" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"triggerType" : "PUSH"
}, {
"hash" : "27095134441ec13971f36c873bca2a03d904cf36",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11700",
"triggerID" : "27095134441ec13971f36c873bca2a03d904cf36",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 27095134441ec13971f36c873bca2a03d904cf36 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11700)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
}, {
"hash" : "fd814d3852fa018df06a8854b65d83493338b28c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681",
"triggerID" : "fd814d3852fa018df06a8854b65d83493338b28c",
"triggerType" : "PUSH"
}, {
"hash" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688",
"triggerID" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"triggerType" : "PUSH"
}, {
"hash" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11690",
"triggerID" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"triggerType" : "PUSH"
}, {
"hash" : "27095134441ec13971f36c873bca2a03d904cf36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11700",
"triggerID" : "27095134441ec13971f36c873bca2a03d904cf36",
"triggerType" : "PUSH"
}, {
"hash" : "745ac6c55e31eecc4519c5590f387497ef50eaf9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11876",
"triggerID" : "745ac6c55e31eecc4519c5590f387497ef50eaf9",
"triggerType" : "PUSH"
}, {
"hash" : "4c81f998b5a359dfae299c69d18c93e064c47538",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11903",
"triggerID" : "4c81f998b5a359dfae299c69d18c93e064c47538",
"triggerType" : "PUSH"
}, {
"hash" : "870ee4ebdef1d0d111946c583259c8ff6149f3bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "870ee4ebdef1d0d111946c583259c8ff6149f3bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4c81f998b5a359dfae299c69d18c93e064c47538 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11903)
* 870ee4ebdef1d0d111946c583259c8ff6149f3bd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
}, {
"hash" : "fd814d3852fa018df06a8854b65d83493338b28c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681",
"triggerID" : "fd814d3852fa018df06a8854b65d83493338b28c",
"triggerType" : "PUSH"
}, {
"hash" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688",
"triggerID" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"triggerType" : "PUSH"
}, {
"hash" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11690",
"triggerID" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"triggerType" : "PUSH"
}, {
"hash" : "27095134441ec13971f36c873bca2a03d904cf36",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11700",
"triggerID" : "27095134441ec13971f36c873bca2a03d904cf36",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4acadd0437adb13bffc3b74e76fa09942ab9422 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11690)
* 27095134441ec13971f36c873bca2a03d904cf36 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11700)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a0bb9719e9f50891b73c316c03366367904c7d39 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #14567:
URL: https://github.com/apache/flink/pull/14567#discussion_r555008866
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -26,7 +26,14 @@
import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup;
import org.apache.flink.streaming.api.graph.StreamConfig;
import org.apache.flink.streaming.api.operators.MailboxExecutor;
-import org.apache.flink.streaming.runtime.tasks.SubtaskCheckpointCoordinator;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlignedController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlternatingController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.CheckpointBarrierBehaviourController;
Review comment:
I am fine with either way, but the following explains some of the considerations why they are put in the current way.
`CheckpointedInputGate` is overall an input gate (but just a different type of input gate), that's why I left it in .....runtime.io
`InputProcessorUtil` is mostly createXXXCheckpointedInputGate, that's why I left it with "CheckpointedInputGate"
`UpstreamRecoveryTracker` is channel recovery-related, and that's why I put within .....runtime.io as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
}, {
"hash" : "fd814d3852fa018df06a8854b65d83493338b28c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681",
"triggerID" : "fd814d3852fa018df06a8854b65d83493338b28c",
"triggerType" : "PUSH"
}, {
"hash" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688",
"triggerID" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"triggerType" : "PUSH"
}, {
"hash" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11690",
"triggerID" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"triggerType" : "PUSH"
}, {
"hash" : "27095134441ec13971f36c873bca2a03d904cf36",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11700",
"triggerID" : "27095134441ec13971f36c873bca2a03d904cf36",
"triggerType" : "PUSH"
}, {
"hash" : "745ac6c55e31eecc4519c5590f387497ef50eaf9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11876",
"triggerID" : "745ac6c55e31eecc4519c5590f387497ef50eaf9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 27095134441ec13971f36c873bca2a03d904cf36 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11700)
* 745ac6c55e31eecc4519c5590f387497ef50eaf9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11876)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
}, {
"hash" : "fd814d3852fa018df06a8854b65d83493338b28c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681",
"triggerID" : "fd814d3852fa018df06a8854b65d83493338b28c",
"triggerType" : "PUSH"
}, {
"hash" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688",
"triggerID" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"triggerType" : "PUSH"
}, {
"hash" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11690",
"triggerID" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"triggerType" : "PUSH"
}, {
"hash" : "27095134441ec13971f36c873bca2a03d904cf36",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11700",
"triggerID" : "27095134441ec13971f36c873bca2a03d904cf36",
"triggerType" : "PUSH"
}, {
"hash" : "745ac6c55e31eecc4519c5590f387497ef50eaf9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11876",
"triggerID" : "745ac6c55e31eecc4519c5590f387497ef50eaf9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 745ac6c55e31eecc4519c5590f387497ef50eaf9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11876)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-758600020
Thanks! Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
}, {
"hash" : "fd814d3852fa018df06a8854b65d83493338b28c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681",
"triggerID" : "fd814d3852fa018df06a8854b65d83493338b28c",
"triggerType" : "PUSH"
}, {
"hash" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688",
"triggerID" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fd814d3852fa018df06a8854b65d83493338b28c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681)
* 9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
}, {
"hash" : "fd814d3852fa018df06a8854b65d83493338b28c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681",
"triggerID" : "fd814d3852fa018df06a8854b65d83493338b28c",
"triggerType" : "PUSH"
}, {
"hash" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688",
"triggerID" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"triggerType" : "PUSH"
}, {
"hash" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11690",
"triggerID" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"triggerType" : "PUSH"
}, {
"hash" : "27095134441ec13971f36c873bca2a03d904cf36",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11700",
"triggerID" : "27095134441ec13971f36c873bca2a03d904cf36",
"triggerType" : "PUSH"
}, {
"hash" : "745ac6c55e31eecc4519c5590f387497ef50eaf9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "745ac6c55e31eecc4519c5590f387497ef50eaf9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 27095134441ec13971f36c873bca2a03d904cf36 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11700)
* 745ac6c55e31eecc4519c5590f387497ef50eaf9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #14567:
URL: https://github.com/apache/flink/pull/14567#discussion_r555020073
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -26,7 +26,14 @@
import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup;
import org.apache.flink.streaming.api.graph.StreamConfig;
import org.apache.flink.streaming.api.operators.MailboxExecutor;
-import org.apache.flink.streaming.runtime.tasks.SubtaskCheckpointCoordinator;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlignedController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlternatingController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.CheckpointBarrierBehaviourController;
Review comment:
I don't have opinion about this. Could be moved together.
However one thing, I'm not sure if `org.apache.flink.streaming.runtime.tasks.checkpointing` is the best fit. Those classes have very little in common with `task` package and it's content `StreamTask`, `OperatorChain` etc. Why not to move all of it to `org.apache.flink.streaming.runtime.io.checkpointing`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #14567:
URL: https://github.com/apache/flink/pull/14567#discussion_r555054059
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -26,7 +26,14 @@
import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup;
import org.apache.flink.streaming.api.graph.StreamConfig;
import org.apache.flink.streaming.api.operators.MailboxExecutor;
-import org.apache.flink.streaming.runtime.tasks.SubtaskCheckpointCoordinator;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlignedController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlternatingController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.CheckpointBarrierBehaviourController;
Review comment:
Copied my explanation from the Jira ticket why these classes are moved to the package named this way:
If we do not move SubtaskCheckpointCoordinator(Impl), I think `org.apache.flink.streaming.runtime.checkpointing` is a good choice.
But if we want to move SubtaskCheckpointCoordinator(Impl) together with the above seven classes, I would lean to `org.apache.flink.streaming.runtime.tasks.checkpointing`.
I think it is a good idea to put all checkpointing related classes altogether, so I prefer `org.apache.flink.streaming.runtime.tasks.checkpointing` as a result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #14567:
URL: https://github.com/apache/flink/pull/14567#discussion_r555045765
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -26,7 +26,14 @@
import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup;
import org.apache.flink.streaming.api.graph.StreamConfig;
import org.apache.flink.streaming.api.operators.MailboxExecutor;
-import org.apache.flink.streaming.runtime.tasks.SubtaskCheckpointCoordinator;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlignedController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlternatingController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.CheckpointBarrierBehaviourController;
Review comment:
> Those classes have very little in common with task package
IMO they do have because they run inside (sub)task. In contrast to `CheckpointCoordinator` which runs in JM (and which is in `org.apache.flink.runtime.checkpoint`).
> Why not to move all of it to org.apache.flink.streaming.runtime.io.checkpointing?
I think checkpointing has nothing to with IO except in very general case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
}, {
"hash" : "fd814d3852fa018df06a8854b65d83493338b28c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681",
"triggerID" : "fd814d3852fa018df06a8854b65d83493338b28c",
"triggerType" : "PUSH"
}, {
"hash" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688",
"triggerID" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"triggerType" : "PUSH"
}, {
"hash" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11690",
"triggerID" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fd814d3852fa018df06a8854b65d83493338b28c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681)
* 9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688)
* d4acadd0437adb13bffc3b74e76fa09942ab9422 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11690)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #14567:
URL: https://github.com/apache/flink/pull/14567#discussion_r554980369
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -26,7 +26,14 @@
import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup;
import org.apache.flink.streaming.api.graph.StreamConfig;
import org.apache.flink.streaming.api.operators.MailboxExecutor;
-import org.apache.flink.streaming.runtime.tasks.SubtaskCheckpointCoordinator;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlignedController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlternatingController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.CheckpointBarrierBehaviourController;
Review comment:
Looks like `InputProcessorUtil` also belongs to `checkpointing` as it's sole purpose is to create `CheckpointedInputGate`. And the purpose of the latter is to handle events, mostly checkpoint barriers.
How about moving it too along with `UpstreamRecoveryTracker`/Impl and `CheckpointedInputGate`?
WDYT @pnowojski , @AHeise ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
}, {
"hash" : "fd814d3852fa018df06a8854b65d83493338b28c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681",
"triggerID" : "fd814d3852fa018df06a8854b65d83493338b28c",
"triggerType" : "PUSH"
}, {
"hash" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688",
"triggerID" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"triggerType" : "PUSH"
}, {
"hash" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11690",
"triggerID" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"triggerType" : "PUSH"
}, {
"hash" : "27095134441ec13971f36c873bca2a03d904cf36",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "27095134441ec13971f36c873bca2a03d904cf36",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4acadd0437adb13bffc3b74e76fa09942ab9422 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11690)
* 27095134441ec13971f36c873bca2a03d904cf36 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
}, {
"hash" : "fd814d3852fa018df06a8854b65d83493338b28c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681",
"triggerID" : "fd814d3852fa018df06a8854b65d83493338b28c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a0bb9719e9f50891b73c316c03366367904c7d39 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679)
* fd814d3852fa018df06a8854b65d83493338b28c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #14567:
URL: https://github.com/apache/flink/pull/14567#discussion_r555008866
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -26,7 +26,14 @@
import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup;
import org.apache.flink.streaming.api.graph.StreamConfig;
import org.apache.flink.streaming.api.operators.MailboxExecutor;
-import org.apache.flink.streaming.runtime.tasks.SubtaskCheckpointCoordinator;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlignedController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlternatingController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.CheckpointBarrierBehaviourController;
Review comment:
`CheckpointedInputGate` is overall an input gate (but just a different type of input gate), that's why I left it in .....runtime.io
`InputProcessorUtil` is mostly createXXXCheckpointedInputGate, that's why I left it with "CheckpointedInputGate"
`UpstreamRecoveryTracker` is channel recovery-related, and that's why I put within .....runtime.io as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14567:
URL: https://github.com/apache/flink/pull/14567#issuecomment-755063547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11679",
"triggerID" : "a0bb9719e9f50891b73c316c03366367904c7d39",
"triggerType" : "PUSH"
}, {
"hash" : "fd814d3852fa018df06a8854b65d83493338b28c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11681",
"triggerID" : "fd814d3852fa018df06a8854b65d83493338b28c",
"triggerType" : "PUSH"
}, {
"hash" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11688",
"triggerID" : "9dc5d7a2052df6db3094ca7fed12b0c29bfbfa05",
"triggerType" : "PUSH"
}, {
"hash" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11690",
"triggerID" : "d4acadd0437adb13bffc3b74e76fa09942ab9422",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4acadd0437adb13bffc3b74e76fa09942ab9422 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11690)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #14567: [FLINK-20453][runtime][checkpoint] Move checkpointing classes to an a…
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #14567:
URL: https://github.com/apache/flink/pull/14567#discussion_r555054059
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -26,7 +26,14 @@
import org.apache.flink.runtime.metrics.groups.TaskIOMetricGroup;
import org.apache.flink.streaming.api.graph.StreamConfig;
import org.apache.flink.streaming.api.operators.MailboxExecutor;
-import org.apache.flink.streaming.runtime.tasks.SubtaskCheckpointCoordinator;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlignedController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.AlternatingController;
+import org.apache.flink.streaming.runtime.tasks.checkpointing.CheckpointBarrierBehaviourController;
Review comment:
@pnowojski
Copied my explanation from the Jira ticket why these classes are moved to the package named this way:
If we do not move SubtaskCheckpointCoordinator(Impl), I think `org.apache.flink.streaming.runtime.checkpointing` is a good choice.
But if we want to move SubtaskCheckpointCoordinator(Impl) together with the above seven classes, I would lean to `org.apache.flink.streaming.runtime.tasks.checkpointing`.
I think it is a good idea to put all checkpointing related classes altogether, so I prefer `org.apache.flink.streaming.runtime.tasks.checkpointing` as a result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org