You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/24 04:37:12 UTC
[GitHub] [spark] yorksity opened a new pull request, #38781: [SPARK-41246][core] Solve the problem of RddId negative
yorksity opened a new pull request, #38781:
URL: https://github.com/apache/spark/pull/38781
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
solve the problem occurs in long running tasks, such as stream tasks
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #38781: [SPARK-41246][core] Solve the problem of RddId negative
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on PR #38781:
URL: https://github.com/apache/spark/pull/38781#issuecomment-1346105458
@yorksity Did you see this issue in the real world? If so, do you have any details about the job? Like batch or streaming? How long it takes to hit this issue? etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #38781: [SPARK-41246][core] Solve the problem of RddId negative
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #38781:
URL: https://github.com/apache/spark/pull/38781#issuecomment-1345971038
is the problem caused by integer overflow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #38781: [SPARK-41246][core] Solve the problem of RddId negative
Posted by GitBox <gi...@apache.org>.
mridulm commented on PR #38781:
URL: https://github.com/apache/spark/pull/38781#issuecomment-1345882339
Please update the PR details with description @yorksity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #38781: [SPARK-41246][core] Solve the problem of RddId negative
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38781:
URL: https://github.com/apache/spark/pull/38781#issuecomment-1480416870
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #38781: [SPARK-41246][core] Solve the problem of RddId negative
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #38781:
URL: https://github.com/apache/spark/pull/38781#issuecomment-1328079467
What problem does it cause? there is no detail here or in the JIRA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yorksity commented on pull request #38781: [SPARK-41246][core] Solve the problem of RddId negative
Posted by GitBox <gi...@apache.org>.
yorksity commented on PR #38781:
URL: https://github.com/apache/spark/pull/38781#issuecomment-1345561453
update detail n the JIRA
When BlockManager generates BlockId, BlockId only supports positive rddid, so BlockId generation fails
object BlockId {
val RDD = "rdd_([0-9])_([0-9])".r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #38781: [SPARK-41246][core] Solve the problem of RddId negative
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on PR #38781:
URL: https://github.com/apache/spark/pull/38781#issuecomment-1346101553
> is the problem caused by integer overflow?
@cloud-fan According to the JIRA description, it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] schlosna commented on a diff in pull request #38781: [SPARK-41246][core] Solve the problem of RddId negative
Posted by GitBox <gi...@apache.org>.
schlosna commented on code in PR #38781:
URL: https://github.com/apache/spark/pull/38781#discussion_r1033091561
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -2570,10 +2570,23 @@ class SparkContext(config: SparkConf) extends Logging {
private[spark] def newShuffleId(): Int = nextShuffleId.getAndIncrement()
- private val nextRddId = new AtomicInteger(0)
+ private var nextRddId = new AtomicInteger(0)
Review Comment:
What happens when the RDD ID overflows within a SparkContext? Are there tests that cover these cases?
Curious if it would be better to switch to an AtomicLong and just modulo max int?
```suggestion
private[spark] def newRddId(): Int = nextRddId.getAndIncrement() % Integer.MAX_VALUE.toInt
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] vinodkc commented on a diff in pull request #38781: [SPARK-41246][core] Solve the problem of RddId negative
Posted by GitBox <gi...@apache.org>.
vinodkc commented on code in PR #38781:
URL: https://github.com/apache/spark/pull/38781#discussion_r1032832334
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -2570,10 +2570,23 @@ class SparkContext(config: SparkConf) extends Logging {
private[spark] def newShuffleId(): Int = nextShuffleId.getAndIncrement()
- private val nextRddId = new AtomicInteger(0)
+ private var nextRddId = new AtomicInteger(0)
/** Register a new RDD, returning its RDD ID */
- private[spark] def newRddId(): Int = nextRddId.getAndIncrement()
+ private[spark] def newRddId(): Int = {
+ var id = nextRddId.getAndIncrement()
+ if (id >= 0) {
+ return id
+ }
+ this.synchronized {
+ id = nextRddId.getAndIncrement()
+ if (id < 0) {
Review Comment:
Instead of this `if (id < 0)` condition, else part of the previous `if (id >= 0)` can be used
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -2570,10 +2570,23 @@ class SparkContext(config: SparkConf) extends Logging {
private[spark] def newShuffleId(): Int = nextShuffleId.getAndIncrement()
- private val nextRddId = new AtomicInteger(0)
+ private var nextRddId = new AtomicInteger(0)
/** Register a new RDD, returning its RDD ID */
- private[spark] def newRddId(): Int = nextRddId.getAndIncrement()
+ private[spark] def newRddId(): Int = {
+ var id = nextRddId.getAndIncrement()
+ if (id >= 0) {
+ return id
+ }
+ this.synchronized {
+ id = nextRddId.getAndIncrement()
Review Comment:
Can we avoid the duplicate call of 'nextRddId.getAndIncrement()'?
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -2570,10 +2570,23 @@ class SparkContext(config: SparkConf) extends Logging {
private[spark] def newShuffleId(): Int = nextShuffleId.getAndIncrement()
- private val nextRddId = new AtomicInteger(0)
+ private var nextRddId = new AtomicInteger(0)
/** Register a new RDD, returning its RDD ID */
- private[spark] def newRddId(): Int = nextRddId.getAndIncrement()
+ private[spark] def newRddId(): Int = {
+ var id = nextRddId.getAndIncrement()
+ if (id >= 0) {
+ return id
+ }
+ this.synchronized {
+ id = nextRddId.getAndIncrement()
+ if (id < 0) {
+ nextRddId = new AtomicInteger(0)
+ id = nextRddId.getAndIncrement()
Review Comment:
Can we use this?
```
nextRddId = new AtomicInteger(1)
id = nextRddId
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #38781: [SPARK-41246][core] Solve the problem of RddId negative
Posted by GitBox <gi...@apache.org>.
mridulm commented on PR #38781:
URL: https://github.com/apache/spark/pull/38781#issuecomment-1328524944
Agree with @srowen , what is the issue here ?
Also, is it applicable to DataFrame ?
Additionally, if RDD id is wrapping around, it can cause rdd id conflicts - we have to think through the impact of that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on a diff in pull request #38781: [SPARK-41246][core] Solve the problem of RddId negative
Posted by GitBox <gi...@apache.org>.
mridulm commented on code in PR #38781:
URL: https://github.com/apache/spark/pull/38781#discussion_r1045404199
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -2570,10 +2570,23 @@ class SparkContext(config: SparkConf) extends Logging {
private[spark] def newShuffleId(): Int = nextShuffleId.getAndIncrement()
- private val nextRddId = new AtomicInteger(0)
+ private var nextRddId = new AtomicInteger(0)
Review Comment:
You dont need to make this a `var` - see below.
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -2570,10 +2570,20 @@ class SparkContext(config: SparkConf) extends Logging {
private[spark] def newShuffleId(): Int = nextShuffleId.getAndIncrement()
- private val nextRddId = new AtomicInteger(0)
+ private var nextRddId = new AtomicInteger(0)
/** Register a new RDD, returning its RDD ID */
- private[spark] def newRddId(): Int = nextRddId.getAndIncrement()
+ private[spark] def newRddId(): Int = {
+ var id = nextRddId.getAndIncrement()
+ if (id >= 0) {
+ return id
+ }
+ this.synchronized {
+ nextRddId = new AtomicInteger(0)
+ id = nextRddId.getAndIncrement()
+ }
+ id
+ }
Review Comment:
Something like this would remove the need for synchronization, etc
```suggestion
private[spark] def newRddId(): Int = {
nextRddId.getAndUpdate { i =>
var nextValue = i + 1
if (nextValue < 0) {
nextValue = 0
}
nextValue
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yorksity commented on a diff in pull request #38781: [SPARK-41246][core] Solve the problem of RddId negative
Posted by GitBox <gi...@apache.org>.
yorksity commented on code in PR #38781:
URL: https://github.com/apache/spark/pull/38781#discussion_r1045242119
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -2570,10 +2570,23 @@ class SparkContext(config: SparkConf) extends Logging {
private[spark] def newShuffleId(): Int = nextShuffleId.getAndIncrement()
- private val nextRddId = new AtomicInteger(0)
+ private var nextRddId = new AtomicInteger(0)
Review Comment:
What happens when the RDD ID overflows within a SparkContext?
When BlockManager generates BlockId, BlockId only supports positive rddid, so BlockId generation fails.
switch to an AtomicLong ?
The scope of influence is very broad, which may require extensive discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yorksity commented on a diff in pull request #38781: [SPARK-41246][core] Solve the problem of RddId negative
Posted by GitBox <gi...@apache.org>.
yorksity commented on code in PR #38781:
URL: https://github.com/apache/spark/pull/38781#discussion_r1045239652
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -2570,10 +2570,23 @@ class SparkContext(config: SparkConf) extends Logging {
private[spark] def newShuffleId(): Int = nextShuffleId.getAndIncrement()
- private val nextRddId = new AtomicInteger(0)
+ private var nextRddId = new AtomicInteger(0)
/** Register a new RDD, returning its RDD ID */
- private[spark] def newRddId(): Int = nextRddId.getAndIncrement()
+ private[spark] def newRddId(): Int = {
+ var id = nextRddId.getAndIncrement()
+ if (id >= 0) {
+ return id
+ }
+ this.synchronized {
+ id = nextRddId.getAndIncrement()
+ if (id < 0) {
+ nextRddId = new AtomicInteger(0)
+ id = nextRddId.getAndIncrement()
Review Comment:
Thank you for your review. I updated the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] schlosna commented on a diff in pull request #38781: [SPARK-41246][core] Solve the problem of RddId negative
Posted by GitBox <gi...@apache.org>.
schlosna commented on code in PR #38781:
URL: https://github.com/apache/spark/pull/38781#discussion_r1033091561
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -2570,10 +2570,23 @@ class SparkContext(config: SparkConf) extends Logging {
private[spark] def newShuffleId(): Int = nextShuffleId.getAndIncrement()
- private val nextRddId = new AtomicInteger(0)
+ private var nextRddId = new AtomicInteger(0)
Review Comment:
What happens when the RDD ID overflows within a SparkContext? Are there tests that cover these cases?
Curious if it would be better to switch to an AtomicLong and just modulo max int?
```suggestion
private[spark] def newRddId(): Int = (nextRddId.getAndIncrement() % Integer.MAX_VALUE).toInt
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] vinodkc commented on a diff in pull request #38781: [SPARK-41246][core] Solve the problem of RddId negative
Posted by GitBox <gi...@apache.org>.
vinodkc commented on code in PR #38781:
URL: https://github.com/apache/spark/pull/38781#discussion_r1032856365
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -2570,10 +2570,23 @@ class SparkContext(config: SparkConf) extends Logging {
private[spark] def newShuffleId(): Int = nextShuffleId.getAndIncrement()
- private val nextRddId = new AtomicInteger(0)
+ private var nextRddId = new AtomicInteger(0)
/** Register a new RDD, returning its RDD ID */
- private[spark] def newRddId(): Int = nextRddId.getAndIncrement()
+ private[spark] def newRddId(): Int = {
+ var id = nextRddId.getAndIncrement()
+ if (id >= 0) {
+ return id
+ }
+ this.synchronized {
+ id = nextRddId.getAndIncrement()
+ if (id < 0) {
+ nextRddId = new AtomicInteger(0)
+ id = nextRddId.getAndIncrement()
Review Comment:
Can you try this ?
```
nextRddId = new AtomicInteger(1)
id = nextRddId
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38781: [SPARK-41246][core] Solve the problem of RddId negative
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38781:
URL: https://github.com/apache/spark/pull/38781#issuecomment-1327253750
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #38781: [SPARK-41246][core] Solve the problem of RddId negative
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #38781: [SPARK-41246][core] Solve the problem of RddId negative
URL: https://github.com/apache/spark/pull/38781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org