[GitHub] [iceberg] karuppayya commented on a change in pull request #2087: More tests for migrate action

[GitBox <gi...@apache.org>]

karuppayya commented on a change in pull request #2087:
URL: https://github.com/apache/iceberg/pull/2087#discussion_r557481075



##########
File path: spark3/src/test/java/org/apache/iceberg/actions/TestCreateActions.java
##########
@@ -157,6 +168,105 @@ public void testMigratePartitioned() throws Exception {
     assertMigratedFileCount(Actions.migrate(source), source, dest);
   }
 
+  @Test
+  public void testPartitionedTableWithUnRecoveredPartitions() throws Exception {

Review comment:
       Example usecase:
   There is  a location where a external system is writing files every day.
   An external partitioned Hive table is created on top of the location, partitioned on day.
   Once the external table is created, we need to run "ALTER TABLE RECOVER PARTITIONS" or "MSCK REPAIR TABLE" to register the partitions in metastore. .
   
   When we dont recover(register against metastore) a partitions(intentionally or unintentionally), the data corresponding to unrecovered partition is not returned as part of the table scan.
   This test checks if both Spark and Iceberg returns same data, when there are unrecovered partitions




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org