You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Chris Dadej <Ch...@macquarie.com> on 2006/06/08 12:23:29 UTC
PATCH: problem with IE in HTTPS mode
All,
I don't have access to commit changes directly back into
Subversion and am unsure of the exact process of submitting patches so I
figured I would give this a try. I've found a problem when using the
<t:popup> component in IE in HTTPS mode whereby a mixed content message
is thrown up (i.e. "This page contains both secure and nonsecure
items."). The reason for it has been reasonably well documented on the
web but it basically boils down to IE requiring a src attribute in the
iframe otherwise it does not know whether the content inside that iframe
is going to be http or https. Can someone with the appropriate rights
please add the following patch in? The only change was to add to the
iframe src='javascript:void(0)' declaration.
Index: JSPopup.js
===================================================================
--- JSPopup.js (revision 412671)
+++ JSPopup.js (working copy)
@@ -11,7 +11,7 @@
if(iframe == null) {
- orgApacheMyfacesPopupFrameUnder =
document.createElement("<iframe
id='"+orgApacheMyfacesPopupCurrentlyOpenedPopup.id+"_IFRAME'
style='visibility:hidden; position: absolute; top:0px;left:0px;'/>");
+ orgApacheMyfacesPopupFrameUnder =
document.createElement("<iframe
id='"+orgApacheMyfacesPopupCurrentlyOpenedPopup.id+"_IFRAME'
style='visibility:hidden; position: absolute; top:0px;left:0px;'
src='javascript:void(0)'/>");
document.body.insertBefore(orgApacheMyfacesPopupFrameUnder);
} else {
orgApacheMyfacesPopupFrameUnder = iframe;
Thanks
Chris Dadej
Macquarie Bank Limited
ISD - Investment Banking Group
Phone: +612 8232 9987
Mobile: +614 1625 4791
Email: chris.dadej@macquarie.com
NOTICE
This e-mail and any attachments are confidential and may contain copyright material of Macquarie Bank or third parties. If you are not the intended recipient of this email you should not read, print, re-transmit, store or act in reliance on this e-mail or any attachments, and should destroy all copies of them. Macquarie Bank does not guarantee the integrity of any emails or any attached files. The views or opinions expressed are the author's own and may not reflect the views or opinions of Macquarie Bank.
Re: PATCH: problem with IE in HTTPS mode
Posted by Matthias Wessendorf <ma...@apache.org>.
thanks for your interested in myfaces.
can you use the JIRA bug tracker system, when pointing
to bugs or providing patches? If you do, they don't get lost. (see [1])
thx.
matthias
[1] http://issues.apache.org/jira/browse/TOMAHAWK
On 6/8/06, Chris Dadej <Ch...@macquarie.com> wrote:
>
>
>
> All,
>
> I don't have access to commit changes directly back into Subversion
> and am unsure of the exact process of submitting patches so I figured I
> would give this a try. I've found a problem when using the <t:popup>
> component in IE in HTTPS mode whereby a mixed content message is thrown up
> (i.e. "This page contains both secure and nonsecure items."). The reason for
> it has been reasonably well documented on the web but it basically boils
> down to IE requiring a src attribute in the iframe otherwise it does not
> know whether the content inside that iframe is going to be http or https.
> Can someone with the appropriate rights please add the following patch in?
> The only change was to add to the iframe src='javascript:void(0)'
> declaration.
>
> Index: JSPopup.js
> ===================================================================
> --- JSPopup.js (revision 412671)
> +++ JSPopup.js (working copy)
> @@ -11,7 +11,7 @@
>
>
> if(iframe == null) {
> - orgApacheMyfacesPopupFrameUnder =
> document.createElement("<iframe
> id='"+orgApacheMyfacesPopupCurrentlyOpenedPopup.id+"_IFRAME'
> style='visibility:hidden; position: absolute; top:0px;left:0px;'/>");
>
> + orgApacheMyfacesPopupFrameUnder =
> document.createElement("<iframe
> id='"+orgApacheMyfacesPopupCurrentlyOpenedPopup.id+"_IFRAME'
> style='visibility:hidden; position: absolute; top:0px;left:0px;'
> src='javascript:void(0)'/>");
>
>
> document.body.insertBefore(orgApacheMyfacesPopupFrameUnder);
> } else {
> orgApacheMyfacesPopupFrameUnder = iframe;
>
> Thanks
>
> Chris Dadej
> Macquarie Bank Limited
> ISD - Investment Banking Group
> Phone: +612 8232 9987
> Mobile: +614 1625 4791
> Email: chris.dadej@macquarie.com
>
> NOTICE
> This e-mail and any attachments are confidential and may contain copyright
> material of Macquarie Bank or third parties. If you are not the intended
> recipient of this email you should not read, print, re-transmit, store or
> act in reliance on this e-mail or any attachments, and should destroy all
> copies of them. Macquarie Bank does not guarantee the integrity of any
> emails or any attached files. The views or opinions expressed are the
> author's own and may not reflect the views or opinions of Macquarie Bank.
>
--
Matthias Wessendorf
Aechterhoek 18
48282 Emsdetten
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com