[GitHub] [fineract] adamsaghy commented on a diff in pull request #3266: FINERACT-1724: Loan product creation - duplicate short name fix

["adamsaghy (via GitHub)" <gi...@apache.org>]

adamsaghy commented on code in PR #3266:
URL: https://github.com/apache/fineract/pull/3266#discussion_r1236964369


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/service/LoanProductWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -150,6 +155,16 @@ public CommandProcessingResult createLoanProduct(final JsonCommand command) {
 
     }
 
+    private void validateShortName(JsonCommand command) {

Review Comment:
   We dont need this. 
   Please check why the LoanProductWritePlatformServiceJpaRepositoryImpl.handleDataIntegrityIssues() method was not handling this properly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org