You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by GitBox <gi...@apache.org> on 2021/11/30 14:32:09 UTC
[GitHub] [nutch] prakharchaube opened a new pull request #708: fix for NUTCH-2911 contributed by prakharchaube
prakharchaube opened a new pull request #708:
URL: https://github.com/apache/nutch/pull/708
Fix for [NUTCH-2911](https://issues.apache.org/jira/browse/NUTCH-2911)
Changes made : Added a wrapper try-finally block for FetcherRun.run() and called cleanup()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nutch] prakharchaube commented on pull request #708: fix for NUTCH-2911 contributed by prakharchaube
Posted by GitBox <gi...@apache.org>.
prakharchaube commented on pull request #708:
URL: https://github.com/apache/nutch/pull/708#issuecomment-983322914
@sebastian-nagel I have added a catch for InterruptedException, sorry for missing it. I know ideally, we should not catch InterruptedException and simply log it, but the cleanup() call will never throw it in the first place.
Let me know if there are any concerns around this. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nutch] sebastian-nagel commented on pull request #708: fix for NUTCH-2911 contributed by prakharchaube
Posted by GitBox <gi...@apache.org>.
sebastian-nagel commented on pull request #708:
URL: https://github.com/apache/nutch/pull/708#issuecomment-983448276
Hi @prakharchaube, after a second look (sorry about it), you're right.
> ideally, we should not catch InterruptedException
Definitely. The overridden [Mapper run](https://hadoop.apache.org/docs/r3.3.1/api/org/apache/hadoop/mapreduce/Mapper.html#run-org.apache.hadoop.mapreduce.Mapper.Context-) method declares the InterruptedException to be thrown, so the overriding method should just throw it as well. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nutch] prakharchaube commented on pull request #708: fix for NUTCH-2911 contributed by prakharchaube
Posted by GitBox <gi...@apache.org>.
prakharchaube commented on pull request #708:
URL: https://github.com/apache/nutch/pull/708#issuecomment-983482004
Done @sebastian-nagel, please review. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nutch] prakharchaube commented on pull request #708: fix for NUTCH-2911 contributed by prakharchaube
Posted by GitBox <gi...@apache.org>.
prakharchaube commented on pull request #708:
URL: https://github.com/apache/nutch/pull/708#issuecomment-983475816
Yes @sebastian-nagel I do feel that would be the best way to handle it, I noticed even job.waitForCompletion() throws InterruptedException so propagation is intentional, I will make the change and update, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nutch] sebastian-nagel commented on pull request #708: fix for NUTCH-2911 contributed by prakharchaube
Posted by GitBox <gi...@apache.org>.
sebastian-nagel commented on pull request #708:
URL: https://github.com/apache/nutch/pull/708#issuecomment-982823043
Thanks @prakharchaube, good catch. The compilation fails with `Fetcher.java:440: error: unreported exception InterruptedException; must be caught or declared to be thrown` - could you update the PR to catch the exception thrown by the [cleanup](https://hadoop.apache.org/docs/r3.3.1/api/org/apache/hadoop/mapreduce/Mapper.html#cleanup-org.apache.hadoop.mapreduce.Mapper.Context-) method. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nutch] sebastian-nagel merged pull request #708: fix for NUTCH-2911 contributed by prakharchaube
Posted by GitBox <gi...@apache.org>.
sebastian-nagel merged pull request #708:
URL: https://github.com/apache/nutch/pull/708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org