[jira] [Commented] (CASSANDRA-7909) Do not exit nodetool repair when receiving JMX NOTIF_LOST

["Philip S Doctor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-7909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160626#comment-14160626 ] 

Philip S Doctor commented on CASSANDRA-7909:
--------------------------------------------

Hi, I have a question about this ticket.  

Apologies if this is a poor question, I don't usually touch c* code.

NodeProbe is listening to notifications from StorageProxyMBean and JMX connection notifications.

Let's say it loses notification that repair is complete.  In this case, when will the connection close?  Does C* close the connection automatically when repair is complete?  If not it seems like this could be a problem.

> Do not exit nodetool repair when receiving JMX NOTIF_LOST
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-7909
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7909
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Yuki Morishita
>            Assignee: Yuki Morishita
>            Priority: Trivial
>             Fix For: 2.0.11, 2.1.1
>
>         Attachments: 0001-Do-not-quit-nodetool-when-JMX-notif_lost-received.patch
>
>
> {{nodetool repair}} prints out 'Lost notification...' and exits when JMX NOTIF_LOST message is received. But we should not exit right away since that message just indicates some messages are lost because "they arrive so fast that they cannot be delivered to the remote client quickly enough" according to https://weblogs.java.net/blog/emcmanus/archive/2007/08/when_can_jmx_no.html. So we should just continue to listen to events until repair finishes or connection is really closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)