You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@freemarker.apache.org by "dtrunk90 (via GitHub)" <gi...@apache.org> on 2023/07/10 22:20:58 UTC

[GitHub] [freemarker] dtrunk90 opened a new pull request, #95: FREEMARKER-218 - Add jakarta.servlet support

dtrunk90 opened a new pull request, #95:
URL: https://github.com/apache/freemarker/pull/95

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@freemarker.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FREEMARKER-218 - Add jakarta.servlet support [freemarker]

Posted by "ddekany (via GitHub)" <gi...@apache.org>.
ddekany commented on PR #95:
URL: https://github.com/apache/freemarker/pull/95#issuecomment-1871239386

   What features of Servlet/JSP support are you using? I'm asking because support JSP taglibs (TLD-based) might brings some complications, if that has to work on modern containers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@freemarker.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FREEMARKER-218 - Add jakarta.servlet support [freemarker]

Posted by "ddekany (via GitHub)" <gi...@apache.org>.
ddekany commented on PR #95:
URL: https://github.com/apache/freemarker/pull/95#issuecomment-1802037594

   Related discussion on the dev mailing list: [https://lists.apache.org/thread/s15x9gzyhpr9d7cj8ck6kzgz3l6nfjrf](url)
   
   If this approach wins (having a new package inside the usual `freemarker.jar`), I think we will generate these new packages, rather than maintain them manually. Will see... Probably, that's best to address after the Gradle PR was merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@freemarker.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FREEMARKER-218 - Add jakarta.servlet support [freemarker]

Posted by "dtrunk90 (via GitHub)" <gi...@apache.org>.
dtrunk90 closed pull request #95: FREEMARKER-218 - Add jakarta.servlet support
URL: https://github.com/apache/freemarker/pull/95


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@freemarker.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [freemarker] ddekany commented on pull request #95: FREEMARKER-218 - Add jakarta.servlet support

Posted by "ddekany (via GitHub)" <gi...@apache.org>.
ddekany commented on PR #95:
URL: https://github.com/apache/freemarker/pull/95#issuecomment-1630192899

   Something like that should work. At quick glance, the equivalent of `FreemarkerServlet` is missing. So far there was only one of that, but now even the classes that used are moved into the `jakarta` package (I assume).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@freemarker.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FREEMARKER-218 - Add jakarta.servlet support [freemarker]

Posted by "dtrunk90 (via GitHub)" <gi...@apache.org>.
dtrunk90 commented on PR #95:
URL: https://github.com/apache/freemarker/pull/95#issuecomment-1803306668

   > Related discussion on the dev mailing list: https://lists.apache.org/thread/s15x9gzyhpr9d7cj8ck6kzgz3l6nfjrf
   > 
   > If this approach wins (having a new package inside the usual `freemarker.jar`), I think we will generate these new packages, rather than maintain them manually. Will see... Probably, that's best to address after the Gradle PR was merged.
   
   FYI: For gradle there's https://github.com/nebula-plugins/gradle-jakartaee-migration-plugin which could probably help generating the new package.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@freemarker.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org