You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by kh...@apache.org on 2021/09/30 08:09:05 UTC
[maven] branch MNG-7272 updated: Review comments.
This is an automated email from the ASF dual-hosted git repository.
khmarbaise pushed a commit to branch MNG-7272
in repository https://gitbox.apache.org/repos/asf/maven.git
The following commit(s) were added to refs/heads/MNG-7272 by this push:
new cc84b1d Review comments.
cc84b1d is described below
commit cc84b1d5e838140aee731f51828bb6db35535f1c
Author: Karl Heinz Marbaise <kh...@apache.org>
AuthorDate: Thu Sep 30 10:08:50 2021 +0200
Review comments.
---
.../maven/graph/DefaultProjectDependencyGraph.java | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java b/maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java
index 910b610..84f552a 100644
--- a/maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java
+++ b/maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java
@@ -46,13 +46,13 @@ public class DefaultProjectDependencyGraph
implements ProjectDependencyGraph
{
- private ProjectSorter sorter;
+ private final ProjectSorter sorter;
- private List<MavenProject> allProjects;
+ private final List<MavenProject> allProjects;
- private Map<MavenProject, Integer> order;
+ private final Map<MavenProject, Integer> order;
- private Map<String, MavenProject> projects;
+ private final Map<String, MavenProject> projects;
/**
* Creates a new project dependency graph based on the specified projects.
@@ -61,10 +61,10 @@ public class DefaultProjectDependencyGraph
* @throws DuplicateProjectException
* @throws CycleDetectedException
*/
- public DefaultProjectDependencyGraph( Collection<MavenProject> projects )
+ public DefaultProjectDependencyGraph( List<MavenProject> projects )
throws CycleDetectedException, DuplicateProjectException
{
- init( projects, projects );
+ this( projects, projects );
}
/**
@@ -80,13 +80,7 @@ public class DefaultProjectDependencyGraph
final Collection<MavenProject> projects )
throws CycleDetectedException, DuplicateProjectException
{
- init( allProjects, projects );
- }
-
- private void init( Collection<MavenProject> allProjects, final Collection<MavenProject> projects )
- throws CycleDetectedException, DuplicateProjectException
- {
- this.allProjects = Collections.unmodifiableList( new ArrayList<>( allProjects ) );
+ this.allProjects = Collections.unmodifiableList( allProjects );
this.sorter = new ProjectSorter( projects );
this.order = new HashMap<>();
this.projects = new HashMap<>();