[jira] [Commented] (SSHD-838) Lower the log level in Nio2Acceptor.AcceptCompletionHandler#okToReaccept

["Goldstein Lyor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SSHD-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563999#comment-16563999 ] 

Goldstein Lyor commented on SSHD-838:
-------------------------------------

Please publish this as Github PR as it makes it easier to review and comment...

Specifically there are 2 requests:

* Lower the log level - we will need to consider this against the possible benefit of such "loudness" - WARNING(s) are intended to indicate and draw attention to abnormal conditions in the system and I am inclined to believe that
{quote}when a client disconnects before the handshake completes{quote} this falls well within this definition. I am not against lowering the level of the stack trace, but will have to think hard about the warning that the condition occurred.

* {quote}Logging the stacktrace in a single message{quote} this may make the stack trace un-readable... - it is much easier to read if each line is separate

* {quote}too much noise for system administrators who might think there's something wrong with the system{quote} - as previously stated, there *is* something wrong with the system and IMO many administrators would like to know.  This is a general project and we cannot accommodate everyone, so we make choices that we think will satisfy the most users.

BTW, there is a simple solution to this issue - in your logging configuration (e.g., _log4j_, _logback_) set the threshold level for messages originating from {{Nio2Acceptor}} as ERROR and then you won't see these warnings . Of course, you might not see other warning originating from it that are of interest.

Another solution is to employ log analysis tools (there are many out there) and "teach" them what warnings/errors interest *your* solution and which do not (which might be different than what *my* solution or other users' solution might consider warnings/errors of interest).


> Lower the log level in Nio2Acceptor.AcceptCompletionHandler#okToReaccept
> ------------------------------------------------------------------------
>
>                 Key: SSHD-838
>                 URL: https://issues.apache.org/jira/browse/SSHD-838
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: jpalacios
>            Priority: Major
>         Attachments: sshd-nio-acceptor-logging.patch
>
>
> As discussed in [SSHD-833|https://issues.apache.org/jira/browse/SSHD-833], it appears that when a client disconnects before the handshake completes there's some pretty loud logging coming from the {{Nio2Acceptor.AcceptCompletionHandler#okToReaccept}}.
> The entire message is logged at {{WARN}} level. Also, several lines from the stack trace are logged individually at the same level.
> We feel this much logging at {{WARN}} level will be too much noise for system administrators who might think there's something wrong with the system. We propose:
> # Changing the log level to {{DEBUG}} / {{FINE}} 
> # Logging the stacktrace in a single message



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)