You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "James E. King, III (JIRA)" <ji...@apache.org> on 2017/04/06 23:14:42 UTC

[jira] [Resolved] (THRIFT-3627) Missing basic code style consistency of JavaScript.

     [ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James E. King, III resolved THRIFT-3627.
----------------------------------------
       Resolution: Fixed
         Assignee: James E. King, III
    Fix Version/s: 0.11.0

> Missing basic code style consistency of JavaScript.
> ---------------------------------------------------
>
>                 Key: THRIFT-3627
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3627
>             Project: Thrift
>          Issue Type: Improvement
>          Components: JavaScript - Library
>            Reporter: Kazuki Matsuda
>            Assignee: James E. King, III
>            Priority: Minor
>             Fix For: 0.11.0
>
>
> E.g.)
> * No white space in {code}function(args){// beteween `){`{code}
> https://github.com/apache/thrift/blob/84cf363eeedf4cc9bb618bb2b1980696b9f6fc9b/lib/js/src/thrift.js#L1497
> * "Double quoted" (not 'single quoted') string litteral
> https://github.com/apache/thrift/blob/84cf363eeedf4cc9bb618bb2b1980696b9f6fc9b/lib/js/src/thrift.js#L133
> Those errors can be easily fixed by fixjsstyle.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)