[Bug 7111] New: sa-update: wrong exit code with --checkonly (does not find new versions)

[bu...@bugzilla.spamassassin.org]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7111

            Bug ID: 7111
           Summary: sa-update: wrong exit code with --checkonly (does not
                    find new versions)
           Product: Spamassassin
           Version: 3.4.0
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: sa-update
          Assignee: dev@spamassassin.apache.org
          Reporter: alexander.sulfrian@fu-berlin.de

Created attachment 5258
  --> https://issues.apache.org/SpamAssassin/attachment.cgi?id=5258&action=edit
Patch to fix the problem.

Hi,

the current sa-update does not report a found new version with its exit code.
The exit code is always 1.

The problem is introduced with the revision 1028033. The commit removes the
exit code setting if a new version is found: 

http://svn.apache.org/viewvc/spamassassin/trunk/sa-update.raw?r1=1028033&r2=1028032


The attached patch fixes the problem.


Thanks,
Alex

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7111] sa-update: wrong exit code with --checkonly (does not find new versions)

[bu...@bugzilla.spamassassin.org]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7111

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |3.4.1

--- Comment #1 from Mark Martinec <Ma...@ijs.si> ---
> The attached patch fixes the problem.

Thanks, makes sense.

Applied, and clarified the POD section regarding exit value 0:


sa-update: wrong exit code with --checkonly (does not find new versions)
  Sending sa-update.raw
Committed revision 1643877.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7111] sa-update: wrong exit code with --checkonly (does not find new versions)

[bu...@bugzilla.spamassassin.org]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7111

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Mark Martinec <Ma...@ijs.si> ---
Closing.

-- 
You are receiving this mail because:
You are the assignee for the bug.