You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pivot.apache.org by tv...@apache.org on 2009/05/14 23:16:35 UTC

svn commit: r774932 - in /incubator/pivot/trunk/tools/src/pivot/tools/net: BytesReceivedCellRenderer.java RequestCellRenderer.java ResponseCellRenderer.java

Author: tvolkert
Date: Thu May 14 21:16:35 2009
New Revision: 774932

URL: http://svn.apache.org/viewvc?rev=774932&view=rev
Log:
Fixed issues in HTTPClient that were introduced when renderers were called to render with null content

Modified:
    incubator/pivot/trunk/tools/src/pivot/tools/net/BytesReceivedCellRenderer.java
    incubator/pivot/trunk/tools/src/pivot/tools/net/RequestCellRenderer.java
    incubator/pivot/trunk/tools/src/pivot/tools/net/ResponseCellRenderer.java

Modified: incubator/pivot/trunk/tools/src/pivot/tools/net/BytesReceivedCellRenderer.java
URL: http://svn.apache.org/viewvc/incubator/pivot/trunk/tools/src/pivot/tools/net/BytesReceivedCellRenderer.java?rev=774932&r1=774931&r2=774932&view=diff
==============================================================================
--- incubator/pivot/trunk/tools/src/pivot/tools/net/BytesReceivedCellRenderer.java (original)
+++ incubator/pivot/trunk/tools/src/pivot/tools/net/BytesReceivedCellRenderer.java Thu May 14 21:16:35 2009
@@ -28,14 +28,18 @@
     @Override
     public void render(Object value, TableView tableView, TableView.Column column,
         boolean rowSelected, boolean rowHighlighted, boolean rowDisabled) {
-        Transaction transaction = (Transaction)value;
-        Request request = transaction.getRequest();
-        long bytesReceived = request.getBytesReceived();
+        renderStyles(tableView, rowSelected, rowDisabled);
 
-        StringBuilder buf = new StringBuilder();
-        buf.append(bytesReceived);
+        if (value != null) {
+            Transaction transaction = (Transaction)value;
+            Request request = transaction.getRequest();
+            long bytesReceived = request.getBytesReceived();
 
-        setText(buf.toString());
-        renderStyles(tableView, rowSelected, rowDisabled);
+            StringBuilder buf = new StringBuilder();
+            buf.append(bytesReceived);
+
+            setText(buf.toString());
+            renderStyles(tableView, rowSelected, rowDisabled);
+        }
     }
 }

Modified: incubator/pivot/trunk/tools/src/pivot/tools/net/RequestCellRenderer.java
URL: http://svn.apache.org/viewvc/incubator/pivot/trunk/tools/src/pivot/tools/net/RequestCellRenderer.java?rev=774932&r1=774931&r2=774932&view=diff
==============================================================================
--- incubator/pivot/trunk/tools/src/pivot/tools/net/RequestCellRenderer.java (original)
+++ incubator/pivot/trunk/tools/src/pivot/tools/net/RequestCellRenderer.java Thu May 14 21:16:35 2009
@@ -28,15 +28,19 @@
     @Override
     public void render(Object value, TableView tableView, TableView.Column column,
         boolean rowSelected, boolean rowHighlighted, boolean rowDisabled) {
-        Transaction transaction = (Transaction)value;
-        Request httpRequest = transaction.getRequest();
+        renderStyles(tableView, rowSelected, rowDisabled);
 
-        StringBuilder buf = new StringBuilder();
-        buf.append(httpRequest.getMethod());
-        buf.append(" ");
-        buf.append(httpRequest.getLocation().getPath());
+        if (value != null) {
+            Transaction transaction = (Transaction)value;
+            Request httpRequest = transaction.getRequest();
 
-        setText(buf.toString());
-        renderStyles(tableView, rowSelected, rowDisabled);
+            StringBuilder buf = new StringBuilder();
+            buf.append(httpRequest.getMethod());
+            buf.append(" ");
+            buf.append(httpRequest.getLocation().getPath());
+
+            setText(buf.toString());
+            renderStyles(tableView, rowSelected, rowDisabled);
+        }
     }
 }

Modified: incubator/pivot/trunk/tools/src/pivot/tools/net/ResponseCellRenderer.java
URL: http://svn.apache.org/viewvc/incubator/pivot/trunk/tools/src/pivot/tools/net/ResponseCellRenderer.java?rev=774932&r1=774931&r2=774932&view=diff
==============================================================================
--- incubator/pivot/trunk/tools/src/pivot/tools/net/ResponseCellRenderer.java (original)
+++ incubator/pivot/trunk/tools/src/pivot/tools/net/ResponseCellRenderer.java Thu May 14 21:16:35 2009
@@ -28,15 +28,19 @@
     @Override
     public void render(Object value, TableView tableView, TableView.Column column,
         boolean rowSelected, boolean rowHighlighted, boolean rowDisabled) {
-        Transaction transaction = (Transaction)value;
-        Response response = transaction.getResponse();
+        renderStyles(tableView, rowSelected, rowDisabled);
 
-        StringBuilder buf = new StringBuilder();
-        buf.append(response.getStatusCode());
-        buf.append(" ");
-        buf.append(response.getStatusMessage());
+        if (value != null) {
+            Transaction transaction = (Transaction)value;
+            Response response = transaction.getResponse();
 
-        setText(buf.toString());
-        renderStyles(tableView, rowSelected, rowDisabled);
+            StringBuilder buf = new StringBuilder();
+            buf.append(response.getStatusCode());
+            buf.append(" ");
+            buf.append(response.getStatusMessage());
+
+            setText(buf.toString());
+            renderStyles(tableView, rowSelected, rowDisabled);
+        }
     }
 }