You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by sr...@apache.org on 2018/09/28 10:32:04 UTC
[incubator-plc4x] 02/05: [General] Added TODO about broken PUB/SUB
implementation in PLC4J
This is an automated email from the ASF dual-hosted git repository.
sruehl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git
commit 1acd5f5c4910f3899a231dafb71e00ad5aede371
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Fri Sep 28 12:05:51 2018 +0200
[General] Added TODO about broken PUB/SUB implementation in PLC4J
---
.../apache/plc4x/java/base/messages/DefaultPlcSubscriptionRequest.java | 1 +
.../apache/plc4x/java/base/messages/DefaultPlcUnsubscriptionRequest.java | 1 +
2 files changed, 2 insertions(+)
diff --git a/plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/messages/DefaultPlcSubscriptionRequest.java b/plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/messages/DefaultPlcSubscriptionRequest.java
index 9f59cb3..3194cf5 100644
--- a/plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/messages/DefaultPlcSubscriptionRequest.java
+++ b/plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/messages/DefaultPlcSubscriptionRequest.java
@@ -30,6 +30,7 @@ import java.time.Duration;
import java.util.*;
import java.util.function.BiFunction;
+// TODO: request broken needs finishing.
public class DefaultPlcSubscriptionRequest implements InternalPlcSubscriptionRequest, InternalPlcFieldRequest {
@Override
diff --git a/plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/messages/DefaultPlcUnsubscriptionRequest.java b/plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/messages/DefaultPlcUnsubscriptionRequest.java
index 5dbccea..03e1f3e 100644
--- a/plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/messages/DefaultPlcUnsubscriptionRequest.java
+++ b/plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/messages/DefaultPlcUnsubscriptionRequest.java
@@ -27,6 +27,7 @@ import org.apache.plc4x.java.base.model.InternalPlcSubscriptionHandle;
import java.util.*;
import java.util.stream.Collectors;
+// TODO: request broken needs finishing.
public class DefaultPlcUnsubscriptionRequest implements InternalPlcUnsubscriptionRequest, InternalPlcFieldRequest {
private final Collection<? extends InternalPlcSubscriptionHandle> internalPlcSubscriptionHandles;