[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #1921: HBASE-24579: Failed SASL authentication does not result in an exception on client side

[GitBox <gi...@apache.org>]

BukrosSzabolcs commented on a change in pull request #1921:
URL: https://github.com/apache/hbase/pull/1921#discussion_r441601004



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
##########
@@ -148,6 +148,18 @@ public boolean saslConnect(InputStream inS, OutputStream outS) throws IOExceptio
           inStream.readFully(saslToken);
         }
       }
+
+      if(isComplete()){
+        try {
+          readStatus(inStream);
+        }
+        catch (Exception e){
+          if(e instanceof RemoteException){
+            LOG.debug("Sasl connection failed: ", e);

Review comment:
       I would prefer to keep it on debug here and only log it on error level where it is handled. It keeps the log cleaner.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org