You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by drigodwin <gi...@git.apache.org> on 2017/09/20 21:13:18 UTC
[GitHub] brooklyn-dist pull request #108: Fix release scripts
GitHub user drigodwin opened a pull request:
https://github.com/apache/brooklyn-dist/pull/108
Fix release scripts
This makes the following changes to the release scripts:
* Fixes a typo in the maven version which is installed
* Doesn't copy over the local gpg keyring
This is because it just uses the first one and if there are multiple keys on it, the wrong one will probably be used. Just manually copy on the keys (I'll amend the docs to document this).
* Updates the CLI artefacts with new structure
* Fixes the path to the built RPM
* Adds the deb
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/drigodwin/brooklyn-dist fix-scripts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-dist/pull/108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #108
----
commit 4fb66438bbe1940e255959bdf0d9152ce9f3124e
Author: Duncan Godwin <du...@cloudsoftcorp.com>
Date: 2017-09-20T21:09:22Z
Fix release scripts
----
---
[GitHub] brooklyn-dist pull request #108: Fix release scripts
Posted by m4rkmckenna <gi...@git.apache.org>.
Github user m4rkmckenna commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/108#discussion_r141637687
--- Diff: release/Vagrantfile ---
@@ -76,7 +78,7 @@ Vagrant.configure(2) do |config|
apt-get install -y default-jdk git subversion xmlstarlet zip unzip language-pack-en \
vim-nox gnupg2 gnupg-agent pinentry-curses golang rpm mmv haveged
mkdir -p /opt
- MAVEN_VERSION=3.3.39
+ MAVEN_VERSION=3.3.3
--- End diff --
why not `apt-get install maven`
---
[GitHub] brooklyn-dist pull request #108: Fix release scripts
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-dist/pull/108
---
[GitHub] brooklyn-dist pull request #108: Fix release scripts
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/108#discussion_r141639106
--- Diff: release/Vagrantfile ---
@@ -76,7 +78,7 @@ Vagrant.configure(2) do |config|
apt-get install -y default-jdk git subversion xmlstarlet zip unzip language-pack-en \
vim-nox gnupg2 gnupg-agent pinentry-curses golang rpm mmv haveged
mkdir -p /opt
- MAVEN_VERSION=3.3.39
+ MAVEN_VERSION=3.3.3
--- End diff --
Because the latest default install of maven on Ubuntu doesn't work with our current build.
---