You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/03 13:50:00 UTC
[jira] [Commented] (ORC-260) masking data for Decimal might not
work as expected because of a bug in DecimalRedactConverter
[ https://issues.apache.org/jira/browse/ORC-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237613#comment-16237613 ]
ASF GitHub Bot commented on ORC-260:
------------------------------------
GitHub user moresandeep opened a pull request:
https://github.com/apache/orc/pull/187
ORC-260 - Fix a bug in masking data for Decimal
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/moresandeep/orc ORC-260
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/187.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #187
----
commit bbc89bd6ef5dc7e84139190d9b8679884e5ace0f
Author: Sandeep More <mo...@apache.org>
Date: 2017-11-03T13:47:48Z
ORC-260 - Fix a bug in masking data for Decimal
----
> masking data for Decimal might not work as expected because of a bug in DecimalRedactConverter
> ----------------------------------------------------------------------------------------------
>
> Key: ORC-260
> URL: https://issues.apache.org/jira/browse/ORC-260
> Project: ORC
> Issue Type: Bug
> Components: Java
> Reporter: Sandeep More
> Priority: Normal
>
> In the DecimalRedactConverter.maskData() function
> {code}
> else {
> for(int r = start; r < start + length; ++r) {
> target.isNull[r] = source.isNull[r];
> if (target.noNulls || !target.isNull[r]) {
> target.vector[r].set(source.vector[r]);
> }
> {code}
> should be
> {code}
> else {
> for(int r = start; r < start + length; ++r) {
> target.isNull[r] = source.isNull[r];
> if (target.noNulls || !target.isNull[r]) {
> target.vector[r].set(maskDecimal(source.vector[r]));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)