You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/11/01 07:20:38 UTC
[GitHub] [iceberg] openinx opened a new issue #3431: Flink: Add unit test to guarantee v2/v1 table without any deletes won't project to exclude the meta-columns.
openinx opened a new issue #3431:
URL: https://github.com/apache/iceberg/issues/3431
Copied from this [comment](https://github.com/apache/iceberg/pull/3240/files#r736304982)
> I think we need to provide a unit test to address the point that if we don't have any eq-deletes or pos-deletes in the task then the best approach is skipping the RowData projection removing the extra columns. In other word :
> * If it's iceberg v1 table, then we need to assert that the iterator won't do any extra projection to exclude the meta-columns;
> * if it's iceberg v2 table and there are some eq-deletes or pos-deletes inside it, then we must guarantee that it is projecting the columns to exclude the extra meta columns.
> The correct approach to address the above cases in unit tests is : we create a separate unit case with an iceberg table, the iceberg table can be v1 table or v2 table. For the v1 table, we just write few records into it. Finally we use the FlinkInputFormat or DataIterator to open this table and assert the returned RowDatas are not a RowDataProjection type. For the v2 table, the difference is the returned RowData is a RowDataProjection type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] openinx closed issue #3431: Flink: Add unit test to guarantee v2/v1 table without any deletes won't project to exclude the meta-columns.
Posted by GitBox <gi...@apache.org>.
openinx closed issue #3431:
URL: https://github.com/apache/iceberg/issues/3431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] openinx commented on issue #3431: Flink: Add unit test to guarantee v2/v1 table without any deletes won't project to exclude the meta-columns.
Posted by GitBox <gi...@apache.org>.
openinx commented on issue #3431:
URL: https://github.com/apache/iceberg/issues/3431#issuecomment-1081625703
Closed via https://github.com/apache/iceberg/pull/3240.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org