You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/09 07:06:58 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29044: [SPARK-32227] Fix regression bug in load-spark-env.cmd with Spark 3.0.0

HyukjinKwon commented on a change in pull request #29044:
URL: https://github.com/apache/spark/pull/29044#discussion_r452007377



##########
File path: bin/load-spark-env.cmd
##########
@@ -29,10 +29,7 @@ if [%SPARK_ENV_LOADED%] == [] (
     set SPARK_CONF_DIR=%~dp0..\conf
   )
 
-  set SPARK_ENV_CMD=%SPARK_CONF_DIR%\%SPARK_ENV_CMD%
-  if exist %SPARK_ENV_CMD% (
-    call %SPARK_ENV_CMD%
-  )
+  call :LoadSparkEnv

Review comment:
       Yeah .. I vaguely remember setting env twice isn't allowed ..




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org