[GitHub] zeppelin pull request #2013: [ZEPPELIN-2091] Disable add/remove operations i...

[soralee <gi...@git.apache.org>]

GitHub user soralee opened a pull request:

    https://github.com/apache/zeppelin/pull/2013

    [ZEPPELIN-2091] Disable add/remove operations in the window of Link this paragraph

    ### What is this PR for?
    When a paragraph is added or deleted from a note, the window which is created by `Link this paragraph` does unnecessary work.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    * [ZEPPELIN-2091](https://issues.apache.org/jira/browse/ZEPPELIN-2091)
    
    ### How should this be tested?
    Here is the test way.
    1. click "Link this paragraph" of a paragraph menu.
    2. click `Insert New` or `remove`.
    3. check the window made by "Link this paragraph". 
    
    ### Screenshots (if appropriate)
    [ Before ]
    * When clicking `Insert New` in a paragraph menu, it appears new paragraph in the window of `Link this paragraph`.
    ![z_2091_b](https://cloud.githubusercontent.com/assets/8110458/22874942/29993076-f20c-11e6-827f-01afe1189744.gif)
    * When click `remove` in a paragraph menu, the window of `Link this paragraph` appears empty screen.
    ![z_2091_b_remove](https://cloud.githubusercontent.com/assets/8110458/22874973/5fcab71e-f20c-11e6-9415-22f3fe84456e.png)
    
    
    [ After ]
    * It doesn't work in the window of 'Link this paragraph`
    ![z_2091_a](https://cloud.githubusercontent.com/assets/8110458/22875086/1c3530f0-f20d-11e6-98a8-6eca2e56ce1c.png)
    
     * _Note that text and title shape of the paragraph in window is covering https://github.com/apache/zeppelin/pull/1983._
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin ZEPPELIN-2091_fix_link_paragraph

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2013.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2013
    
----
commit 9e8ff4188f174b2acc04be04ff4be1a4416cef82
Author: soralee <so...@zepl.com>
Date:   2017-02-13T07:17:44Z

    disable add/remove function in Link this paragraph window

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2013: [ZEPPELIN-2091] Disable add/remove operations in the w...

[Leemoonsoo <gi...@git.apache.org>]

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2013
  
    Tested and LGTM.
    CI failure is not related.
    merge to master and branch-0.7 if no more discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2013: [ZEPPELIN-2091] Disable add/remove operations i...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2013


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---