[GitHub] [trafficserver] duke8253 commented on pull request #7883: Origin session cache mem leak fix

[GitBox <gi...@apache.org>]

duke8253 commented on pull request #7883:
URL: https://github.com/apache/trafficserver/pull/7883#issuecomment-868716612


   As mentioned above, we didn't follow OpenSSL's documentation on how we handle the new session callback. I tried making the callback for origin sessions do the same thing as server sessions, but looks like we deal with origin session differently too so the memory leak still happens even if I the call back returns 0 all the time, seems like we rely on openssl's own freeing mechanism on the origin side but not the server side. That's why I removed the whole `i2d_SSL_SESSION` conversion part. As for the `exdata`, as we only use it to store a single integer value, I see no reason to pass it as a pointer to a structure. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org