You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Mark Phippard <ma...@softlanding.com> on 2005/10/27 18:03:12 UTC
[PATCH] Modify JavaHL test suite to use SVNClientSynchronized class
It seems like the JavaHL test suite would be better served by constructing
an SVNClientSynchronized instead of an SVNClient. The former just wraps
Java thread synchrnonization around the latter and by using it, you
essentially are testing both classes.
This would have caught the problem for the other patch I just sent.
Thanks
Mark
Index: src/org/tigris/subversion/javahl/tests/SVNTests.java
===================================================================
--- src/org/tigris/subversion/javahl/tests/SVNTests.java (revision
17058)
+++ src/org/tigris/subversion/javahl/tests/SVNTests.java (working
copy)
@@ -211,7 +211,7 @@
// create and configure the needed subversion objects
admin = new SVNAdmin();
- client = new SVNClient();
+ client = new SVNClientSynchronized();
client.notification2(new MyNotifier());
client.commitMessageHandler(new MyCommitMessage());
client.username("jrandom");
_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Modify JavaHL test suite to use SVNClientSynchronized class
Posted by Daniel Rall <dl...@collab.net>.
On Thu, 27 Oct 2005, Mark Phippard wrote:
> It seems like the JavaHL test suite would be better served by constructing
> an SVNClientSynchronized instead of an SVNClient. The former just wraps
> Java thread synchrnonization around the latter and by using it, you
> essentially are testing both classes.
>
> This would have caught the problem for the other patch I just sent.
Yup, thanks Mark. Committed as r17066.
--
Daniel Rall
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org