You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by br...@apache.org on 2014/12/15 03:05:20 UTC
svn commit: r1645547 - in /subversion/branches: 1.7.x/STATUS 1.8.x/STATUS
Author: brane
Date: Mon Dec 15 02:05:20 2014
New Revision: 1645547
URL: http://svn.apache.org/r1645547
Log:
* STATUS: Propose fix for "make davautocheck" with HTTPd 2.4+.
Modified:
subversion/branches/1.7.x/STATUS
subversion/branches/1.8.x/STATUS
Modified: subversion/branches/1.7.x/STATUS
URL: http://svn.apache.org/viewvc/subversion/branches/1.7.x/STATUS?rev=1645547&r1=1645546&r2=1645547&view=diff
==============================================================================
--- subversion/branches/1.7.x/STATUS (original)
+++ subversion/branches/1.7.x/STATUS Mon Dec 15 02:05:20 2014
@@ -73,6 +73,17 @@ Candidate changes:
Votes:
+1: philip
+ * r1544302, r1544303
+ Add HTTPd lock file configuration for testing against HTTPd 2.4+.
+ Justification:
+ Without this change, the davautocheck tests do not work on some
+ systems where HTTPd 2.4+ is the default; OSX 10.10 is one such case.
+ Notes:
+ As far as I'm concerned, this blocks 1.7.19 and 1.8.11 since the
+ tests won't run on a current version of a supported OS.
+ Votes:
+ +1: brane
+
Veto-blocked changes:
=====================
Modified: subversion/branches/1.8.x/STATUS
URL: http://svn.apache.org/viewvc/subversion/branches/1.8.x/STATUS?rev=1645547&r1=1645546&r2=1645547&view=diff
==============================================================================
--- subversion/branches/1.8.x/STATUS (original)
+++ subversion/branches/1.8.x/STATUS Mon Dec 15 02:05:20 2014
@@ -111,6 +111,17 @@ Candidate changes:
Votes:
+1: philip
+ * r1544302, r1544303
+ Add HTTPd lock file configuration for testing against HTTPd 2.4+.
+ Justification:
+ Without this change, the davautocheck tests do not work on some
+ systems where HTTPd 2.4+ is the default; OSX 10.10 is one such case.
+ Notes:
+ As far as I'm concerned, this blocks 1.7.19 and 1.8.11 since the
+ tests won't run on a current version of a supported OS.
+ Votes:
+ +1: brane
+
Veto-blocked changes:
=====================
Re: 1.7.19 and 1.8.11 [was: svn commit: r1645547 - in /subversion/branches: 1.7.x/STATUS 1.8.x/STATUS]
Posted by Julian Foad <ju...@btopenworld.com>.
Branko Čibej wrote:
> On 15.12.2014 13:23, Julian Foad wrote:
>> Since upgrading to Ubuntu 14.04 which has httpd 2.4, I found
>> 'davautocheck' fails at the configuration checking stage:
>>
>> AH00534: apache2: Configuration error: No MPM loaded.
>> davautocheck.sh: Configuration file didn't pass the check, most likely
>> modules couldn't be loaded
>
> That's a different issue, i.e., there's no default MPM compiled into
> HTTPd.
[...]
>> Does that appear to be the same issue you found?
>
> No; I suggest trying with APACHE_MPM=prefork with the current state of
> the 1.8.x branch, that's a more likely trigger. Unless 2.4 behaves
> differently on Linux and doesn't require a lock file for prefork.
FWIW that seems to work fine for me.
- Julian
Re: 1.7.19 and 1.8.11 [was: svn commit: r1645547 - in /subversion/branches:
1.7.x/STATUS 1.8.x/STATUS]
Posted by Branko Čibej <br...@wandisco.com>.
On 15.12.2014 13:23, Julian Foad wrote:
> Branko Čibej wrote:
>
>> On 15.12.2014 04:30, Ben Reser wrote:
>>> On 12/14/14 6:11 PM, Branko Čibej wrote:
>>>> As you've all seen, I voted against releasing 1.7.19 and 1.8.11, because
>>>> the DAV tests don't work with HTTPd 2.4+, which is the system default on
>>>> the latest version of OSX. I'd be surprised if OSX is the exception; it
>>>> seems to depend not just on the HTTPd version but also on the configured
>>>> MPM.
>>>>
>>>> I found that we've had the fix on trunk in davautocheck.sh for over a
>>>> year, and have proposed to backport it to 1.7.x and 1.8.x; it's a clean
>>>> merge.
>>>>
>>>> I therefore propose that we scratch the 1.7.19 and 1.8.11 releases,
>>>> approve the backport and roll 1.7.20 and 1.8.12 with the fix included.
>>> I don't disagree we should fix this. But it's not a regression.
>> No, it isn't, which is why I wrote "vote against", not "veto". But it's
>> an easily-fixed nuisance. ISTR Julian mentioned he had similar
>> intermittent problems on Linux ... which might nor might not have the
>> same cause.
> Since upgrading to Ubuntu 14.04 which has httpd 2.4, I found 'davautocheck' fails at the configuration checking stage:
>
> AH00534: apache2: Configuration error: No MPM loaded.
> davautocheck.sh: Configuration file didn't pass the check, most likely
> modules couldn't be loaded
That's a different issue, i.e., there's no default MPM compiled into HTTPd.
> On
> bypassing the checks in davautocheck.sh, httpd failed to start. At one point while experimenting with these things, the OS crash reporter reported that httpd had crashed, but I don't know which attempt that was.
>
> I tried going back to Subversion 1.8.8 and 1.8.0 they fail in the same way.
>
> Setting
> 'APACHE_MPM=worker' made the test suite work and pass all tests. Although it's nice if everything works automatically, this is good
> enough for me.
>
> Later I tried with 'prefork', and that works too, and all tests pass. But with 'APACHE_MPM=event', usually (but not always) some tests fail (for example, one or more of: externals_tests.py 2 5 7 12 15; merge_automatic_tests.py 13).
>
> Does that appear to be the same issue you found?
No; I suggest trying with APACHE_MPM=prefork with the current state of
the 1.8.x branch, that's a more likely trigger. Unless 2.4 behaves
differently on Linux and doesn't require a lock file for prefork.
-- Brane
>
> You also reported:
>> - Two swig-rb tests fail:
>>
>> -- SvnClientTest#test_diff
>> -- SvnClientTest#test_diff_peg
>>
>> It looks like these tests should use the --internal-diff flag,
>> or create their own config directory; i.e., this is a bug in
>> the tests rather than in the bindings.
>>
>> (My default svn config sets diff-cmd to colorize the diff output,
>> which causes the regular expressions in the test to not match.)
> The
> swig-rb tests use the Subversion configuration in the user's home
> directory and fail or behave differently if you have certain settings
> there. (In my case, Subversion 'diff' pops up a GUI.) They should
> instead use their own config dir.
>
> I tried with various 1.8.x tags and found this problem was introduced in 1.8.9.
>
> I worked around that problem by setting environment variable 'HOME' to a temporary directory.
Yup, this is really a minor bug in the test suite.
-- Brane
Re: 1.7.19 and 1.8.11 [was: svn commit: r1645547 - in /subversion/branches: 1.7.x/STATUS 1.8.x/STATUS]
Posted by Julian Foad <ju...@btopenworld.com>.
Branko Čibej wrote:
> On 15.12.2014 04:30, Ben Reser wrote:
>> On 12/14/14 6:11 PM, Branko Čibej wrote:
>>> As you've all seen, I voted against releasing 1.7.19 and 1.8.11, because
>>> the DAV tests don't work with HTTPd 2.4+, which is the system default on
>>> the latest version of OSX. I'd be surprised if OSX is the exception; it
>>> seems to depend not just on the HTTPd version but also on the configured
>>> MPM.
>>>
>>> I found that we've had the fix on trunk in davautocheck.sh for over a
>>> year, and have proposed to backport it to 1.7.x and 1.8.x; it's a clean
>>> merge.
>>>
>>> I therefore propose that we scratch the 1.7.19 and 1.8.11 releases,
>>> approve the backport and roll 1.7.20 and 1.8.12 with the fix included.
>>
>> I don't disagree we should fix this. But it's not a regression.
>
> No, it isn't, which is why I wrote "vote against", not "veto". But it's
> an easily-fixed nuisance. ISTR Julian mentioned he had similar
> intermittent problems on Linux ... which might nor might not have the
> same cause.
Since upgrading to Ubuntu 14.04 which has httpd 2.4, I found 'davautocheck' fails at the configuration checking stage:
AH00534: apache2: Configuration error: No MPM loaded.
davautocheck.sh: Configuration file didn't pass the check, most likely
modules couldn't be loaded
On
bypassing the checks in davautocheck.sh, httpd failed to start. At one point while experimenting with these things, the OS crash reporter reported that httpd had crashed, but I don't know which attempt that was.
I tried going back to Subversion 1.8.8 and 1.8.0 they fail in the same way.
Setting
'APACHE_MPM=worker' made the test suite work and pass all tests. Although it's nice if everything works automatically, this is good
enough for me.
Later I tried with 'prefork', and that works too, and all tests pass. But with 'APACHE_MPM=event', usually (but not always) some tests fail (for example, one or more of: externals_tests.py 2 5 7 12 15; merge_automatic_tests.py 13).
Does that appear to be the same issue you found?
You also reported:
> - Two swig-rb tests fail:
>
> -- SvnClientTest#test_diff
> -- SvnClientTest#test_diff_peg
>
> It looks like these tests should use the --internal-diff flag,
> or create their own config directory; i.e., this is a bug in
> the tests rather than in the bindings.
>
> (My default svn config sets diff-cmd to colorize the diff output,
> which causes the regular expressions in the test to not match.)
The
swig-rb tests use the Subversion configuration in the user's home
directory and fail or behave differently if you have certain settings
there. (In my case, Subversion 'diff' pops up a GUI.) They should
instead use their own config dir.
I tried with various 1.8.x tags and found this problem was introduced in 1.8.9.
I worked around that problem by setting environment variable 'HOME' to a temporary directory.
- Julian
Re: 1.7.19 and 1.8.11 [was: svn commit: r1645547 - in /subversion/branches:
1.7.x/STATUS 1.8.x/STATUS]
Posted by Branko Čibej <br...@wandisco.com>.
On 15.12.2014 04:30, Ben Reser wrote:
> On 12/14/14 6:11 PM, Branko Čibej wrote:
>> As you've all seen, I voted against releasing 1.7.19 and 1.8.11, because
>> the DAV tests don't work with HTTPd 2.4+, which is the system default on
>> the latest version of OSX. I'd be surprised if OSX is the exception; it
>> seems to depend not just on the HTTPd version but also on the configured
>> MPM.
>>
>> I found that we've had the fix on trunk in davautocheck.sh for over a
>> year, and have proposed to backport it to 1.7.x and 1.8.x; it's a clean
>> merge.
>>
>> I therefore propose that we scratch the 1.7.19 and 1.8.11 releases,
>> approve the backport and roll 1.7.20 and 1.8.12 with the fix included.
> I don't disagree we should fix this. But it's not a regression.
No, it isn't, which is why I wrote "vote against", not "veto". But it's
an easily-fixed nuisance. ISTR Julian mentioned he had similar
intermittent problems on Linux ... which might nor might not have the
same cause.
> There are at least four possible workarounds.
> 1) Set the APACHE_MPM environment variable to something other than event.
> 2) Apply patches to the auto script (the backports you proposed).
> 3) Choose a different MPM at httpd build time.
> 4) Don't use davautocheck.sh and setup the httpd config yourself.
>
> The first of which is very low difficulty for anyone. It's something you need
> to do if for instance you have an event default MPM httpd and what to run
> mod_dav tests against BDB since we disallow event with BDB anyway.
Your fix in r1544303 is for prefork, which is the default on OSX 10.10.
If I can use neither event, nor prefork without the fix, there aren't
many options left. As for your point (3), I propose you use that
argument to all the people who're bound to complain about a broken
davautocheck. :)
> davautocheck.sh is a convenience feature of the test suite at this point.
Ho hum ... if that's the case, we may as well say that the whole test
suite is a convenience feature and not worry about test failures during
release testing.
I suspect a lot of downstream packagers tend to rely on 'make
davautocheck' to vet their packages, and HTTPd 2.4 is becoming more
widespread ... which is why I think it makes sense to fix this
"convenience" for our users, even if we know there are workarounds.
> I'm
> sure it has numerous other failings in certain circumstances. 1.6.x wouldn't
> work on OS X either as I recall, yet nobody complained about it back then.
>
> Given that you've already located the correct fixes and nominated them, in my
> opinion we should just ship this release as is and then be sure to fix them for
> the next release.
>
> So my vote is not to delay this release.
I'm not going to try to stop the release, more than I've already done.
But I won't sign the tarballs; IMO, the release is broken, and given
that we've had a fix on trunk for more than a year, there's no reason
not to fix it. It's not as if we're in any particular hurry to roll
these releases right this minute.
-- Brane
Re: 1.7.19 and 1.8.11 [was: svn commit: r1645547 - in /subversion/branches:
1.7.x/STATUS 1.8.x/STATUS]
Posted by Ben Reser <be...@reser.org>.
On 12/14/14 6:11 PM, Branko Čibej wrote:
> As you've all seen, I voted against releasing 1.7.19 and 1.8.11, because
> the DAV tests don't work with HTTPd 2.4+, which is the system default on
> the latest version of OSX. I'd be surprised if OSX is the exception; it
> seems to depend not just on the HTTPd version but also on the configured
> MPM.
>
> I found that we've had the fix on trunk in davautocheck.sh for over a
> year, and have proposed to backport it to 1.7.x and 1.8.x; it's a clean
> merge.
>
> I therefore propose that we scratch the 1.7.19 and 1.8.11 releases,
> approve the backport and roll 1.7.20 and 1.8.12 with the fix included.
I don't disagree we should fix this. But it's not a regression.
There are at least four possible workarounds.
1) Set the APACHE_MPM environment variable to something other than event.
2) Apply patches to the auto script (the backports you proposed).
3) Choose a different MPM at httpd build time.
4) Don't use davautocheck.sh and setup the httpd config yourself.
The first of which is very low difficulty for anyone. It's something you need
to do if for instance you have an event default MPM httpd and what to run
mod_dav tests against BDB since we disallow event with BDB anyway.
davautocheck.sh is a convenience feature of the test suite at this point. I'm
sure it has numerous other failings in certain circumstances. 1.6.x wouldn't
work on OS X either as I recall, yet nobody complained about it back then.
Given that you've already located the correct fixes and nominated them, in my
opinion we should just ship this release as is and then be sure to fix them for
the next release.
So my vote is not to delay this release.
1.7.19 and 1.8.11 [was: svn commit: r1645547 - in /subversion/branches:
1.7.x/STATUS 1.8.x/STATUS]
Posted by Branko Čibej <br...@wandisco.com>.
As you've all seen, I voted against releasing 1.7.19 and 1.8.11, because
the DAV tests don't work with HTTPd 2.4+, which is the system default on
the latest version of OSX. I'd be surprised if OSX is the exception; it
seems to depend not just on the HTTPd version but also on the configured
MPM.
I found that we've had the fix on trunk in davautocheck.sh for over a
year, and have proposed to backport it to 1.7.x and 1.8.x; it's a clean
merge.
I therefore propose that we scratch the 1.7.19 and 1.8.11 releases,
approve the backport and roll 1.7.20 and 1.8.12 with the fix included.
-- Brane
On 15.12.2014 03:05, brane@apache.org wrote:
> Author: brane
> Date: Mon Dec 15 02:05:20 2014
> New Revision: 1645547
>
> URL: http://svn.apache.org/r1645547
> Log:
> * STATUS: Propose fix for "make davautocheck" with HTTPd 2.4+.
>
> Modified:
> subversion/branches/1.7.x/STATUS
> subversion/branches/1.8.x/STATUS
>
> Modified: subversion/branches/1.7.x/STATUS
> URL: http://svn.apache.org/viewvc/subversion/branches/1.7.x/STATUS?rev=1645547&r1=1645546&r2=1645547&view=diff
> ==============================================================================
> --- subversion/branches/1.7.x/STATUS (original)
> +++ subversion/branches/1.7.x/STATUS Mon Dec 15 02:05:20 2014
> @@ -73,6 +73,17 @@ Candidate changes:
> Votes:
> +1: philip
>
> + * r1544302, r1544303
> + Add HTTPd lock file configuration for testing against HTTPd 2.4+.
> + Justification:
> + Without this change, the davautocheck tests do not work on some
> + systems where HTTPd 2.4+ is the default; OSX 10.10 is one such case.
> + Notes:
> + As far as I'm concerned, this blocks 1.7.19 and 1.8.11 since the
> + tests won't run on a current version of a supported OS.
> + Votes:
> + +1: brane
> +
> Veto-blocked changes:
> =====================
>
>
> Modified: subversion/branches/1.8.x/STATUS
> URL: http://svn.apache.org/viewvc/subversion/branches/1.8.x/STATUS?rev=1645547&r1=1645546&r2=1645547&view=diff
> ==============================================================================
> --- subversion/branches/1.8.x/STATUS (original)
> +++ subversion/branches/1.8.x/STATUS Mon Dec 15 02:05:20 2014
> @@ -111,6 +111,17 @@ Candidate changes:
> Votes:
> +1: philip
>
> + * r1544302, r1544303
> + Add HTTPd lock file configuration for testing against HTTPd 2.4+.
> + Justification:
> + Without this change, the davautocheck tests do not work on some
> + systems where HTTPd 2.4+ is the default; OSX 10.10 is one such case.
> + Notes:
> + As far as I'm concerned, this blocks 1.7.19 and 1.8.11 since the
> + tests won't run on a current version of a supported OS.
> + Votes:
> + +1: brane
> +
> Veto-blocked changes:
> =====================
>
>
>