[GitHub] [hadoop] mehakmeet commented on a diff in pull request #4796: HADOOP-18186. s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

[GitBox <gi...@apache.org>]

mehakmeet commented on code in PR #4796:
URL: https://github.com/apache/hadoop/pull/4796#discussion_r963505787


##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3APrefetchingInputStream.java:
##########
@@ -130,6 +131,7 @@ public void testReadLargeFileFully() throws Throwable {
     }
     // Verify that once stream is closed, all memory is freed
     verifyStatisticGaugeValue(ioStats, StreamStatisticNames.STREAM_READ_ACTIVE_MEMORY_IN_USE, 0);
+    assertDurationRange(ioStats, StoreStatisticNames.ACTION_EXECUTOR_ACQUIRED, 0, 10);

Review Comment:
   This would pass for the duration of acquisition executor=0 as well. Think having an `assertThat.isGreaterThan(0)` should be fine as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org