You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tajo.apache.org by jihoonson <gi...@git.apache.org> on 2015/07/28 08:12:01 UTC

[GitHub] tajo pull request: TAJO-1715: Precompute the hash value of various...

GitHub user jihoonson opened a pull request:

    https://github.com/apache/tajo/pull/658

    TAJO-1715: Precompute the hash value of various kinds of ids

    Changes are:
    * Statically maintaining the hash value in TaskId and TaskAttemptId
     * This is because, unlike QueryId and ExecutionBlockId, it is expected there are many tasks and their attempts.
    * Improving TupleMap.put()
     * Copying tuple is expensive, so I implemented the clone() method for KeyTuple.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jihoonson/tajo-2 TAJO-1715

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/658.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #658
    
----
commit 6c44a72990c2177f669c76472dbde87fe81366ba
Author: Jihoon Son <ji...@apache.org>
Date:   2015-07-28T06:08:15Z

    TAJO-1715

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1715: Precompute the hash value of various...

Posted by jinossy <gi...@git.apache.org>.

Github user jinossy commented on the pull request:

    https://github.com/apache/tajo/pull/658#issuecomment-125866576
  
    +1 LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1715: Precompute the hash value of various...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/658


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1715: Precompute the hash value of various...

Posted by jihoonson <gi...@git.apache.org>.

Github user jihoonson commented on the pull request:

    https://github.com/apache/tajo/pull/658#issuecomment-125871590
  
    Thanks for your review!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---