You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Francois Saint-Jacques (Jira)" <ji...@apache.org> on 2019/12/06 15:33:00 UTC

[jira] [Assigned] (ARROW-7338) [C++] Rename SimpleDataSource to InMemoryDataSource

     [ https://issues.apache.org/jira/browse/ARROW-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Francois Saint-Jacques reassigned ARROW-7338:
---------------------------------------------

    Assignee: Francois Saint-Jacques

> [C++] Rename SimpleDataSource to InMemoryDataSource
> ---------------------------------------------------
>
>                 Key: ARROW-7338
>                 URL: https://issues.apache.org/jira/browse/ARROW-7338
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++ - Dataset
>            Reporter: Francois Saint-Jacques
>            Assignee: Francois Saint-Jacques
>            Priority: Major
>
> The constructor should take a generator
> {code:c++}
> // Some comments here
> class InMemoryDataSource : public DataSource {
>   public:
>     using Generator = std::function<Iterator<std::shared_ptr<RecordBatch>()>;
>     InMemoryDataSource(Generator&& generator);
>     // Convenience constructor to support a fixed list of RecordBatch
>     InMemoryDataSource(std::shared_ptr<RecordBatch>);
>     InMemoryDataSource(std::vector<std::shared_ptr<RecordBatch>>);
> private:
>   Generator generator;
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)