You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Lee-W (via GitHub)" <gi...@apache.org> on 2023/08/26 07:16:10 UTC

[GitHub] [airflow] Lee-W commented on pull request #33762: Use literal dict instead of calling dict() in Airflow core

Lee-W commented on PR #33762:
URL: https://github.com/apache/airflow/pull/33762#issuecomment-1694208117

   > Hmmm. Not so sure about this one . I actually like better the dict variant. What's the reason you want to change it @hussein-awala ? (Not strongly opposing - but wanted to know the reasoning).
   
   AFAIK, `{}` seems to perform a bit (not noticeable) better than `dict()`.  I like literal dict a bit better. Especially in a place like [here](https://github.com/apache/airflow/pull/33762/files#diff-59459406f1295699213226e1d1bb5946e5a49cf9da69e68964e95a80817a460dR46)). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org