[GitHub] [hadoop] leosunli commented on a change in pull request #1010: HDFS-13694. Making md5 computing being in parallel with image loading.

[GitBox <gi...@apache.org>]

leosunli commented on a change in pull request #1010: HDFS-13694. Making md5 computing being in parallel with image loading.
URL: https://github.com/apache/hadoop/pull/1010#discussion_r298051286
 
 

 ##########
 File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java
 ##########
 @@ -172,13 +172,55 @@ public LoaderContext getLoaderContext() {
       return ctx;
     }
 
+    /***
+     * a thread for parallel MD5 computing to increase performance when loading
+     */
+    private static class DigestThread extends Thread {
+      volatile private IOException ioe = null;
+      volatile private MD5Hash digest = null;
+      private File file;
+
+      public DigestThread(File inFile) {
+        file = inFile;
+      }
+
+      public MD5Hash getDigest() {
+        return digest;
 
 Review comment:
   if digest have exception ，DigestThread have catch it.
   try {
             digest = MD5FileUtils.computeMd5ForFile(file);
           } catch (IOException e) {
             ioe = e;
           } catch (Throwable t) {
             ioe = new IOException(t);
           }

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org