[GitHub] markusthoemmes commented on a change in pull request #3174: Change log level dynamically (updated)

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #3174: Change log level dynamically (updated)
URL: https://github.com/apache/incubator-openwhisk/pull/3174#discussion_r161568032
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/common/Logging.scala
 ##########
 @@ -37,7 +37,11 @@ trait Logging {
    * @param message Message to write to the log
    */
   def debug(from: AnyRef, message: String)(implicit id: TransactionId = TransactionId.unknown) = {
-    emit(DebugLevel, id, from, message)
+    if (id.meta.extraLogging) {
 
 Review comment:
   I second this. We should apply this to all methods (possibly do it just in `emit`?)! If we decide to run on WARN or on ERROR, you still want *all* logs to appear for those special users, no?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services