You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2026/10/15 07:45:39 UTC
[PR] [fix](timezone)(branch-4.1) Normalize zero-offset time zones for ORC readers [doris]
Gabriel39 opened a new pull request, #69123:
URL: https://github.com/apache/doris/pull/69123
### What problem does this PR solve?
Related PR: #68865
On `branch-4.1`, a session time zone of `+00:00` or `-00:00` is canonicalized by Java to `Z`. ORC treats that value as a zoneinfo filename, so reading an ORC file fails with `Can't open /usr/share/zoneinfo/Z`.
Adapt the zero-offset normalization from #68865 to the existing shared FE helper: send `UTC` for fixed zero-offset zones while preserving nonzero offsets, aliases, and regional historical/DST rules. All existing callers of the helper receive the corrected identifier.
### Release note
Fix ORC reads failing when the session time zone is a zero offset such as `+00:00`.
### Check List (For Author)
- Test
- [x] Unit Test
- [x] Manual test
Validation:
- Recompiled `TimeUtils` and `TimeUtilsTest` against prebuilt FE dependencies and ran JUnitCore: all 10 tests passed. Before the fix, the new zero-offset test failed with expected `UTC`, actual `Z`.
- Coverage includes standardized `+0:00`/`-0:00`, fixed zero-offset names, nonzero fractional offsets, aliases, DST regions, and a region with historical offset changes.
- FE Checkstyle: `mvn -B -pl fe-core -am checkstyle:check`.
- An isolated ORC library probe reproduced the `Z` failure and read the same synthetic ORC file successfully with `UTC`.
- A full Doris build and SQL end-to-end regression were not run locally; CI is requested separately.
- Behavior changed:
- [x] Yes. Fixed zero-offset zones are sent to execution backends as `UTC`.
- Does this need documentation?
- [x] No.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](timezone)(branch-4.1) Normalize zero-offset time zones for ORC readers [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69123:
URL: https://github.com/apache/doris/pull/69123#issuecomment-6187153643
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](timezone)(branch-4.1) Normalize zero-offset time zones for ORC readers [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #69123:
URL: https://github.com/apache/doris/pull/69123#issuecomment-6187154599
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](timezone)(branch-4.1) Normalize zero-offset time zones for ORC readers [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #69123:
URL: https://github.com/apache/doris/pull/69123#issuecomment-6187155058
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](timezone)(branch-4.1) Normalize zero-offset time zones for ORC readers [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #69123:
URL: https://github.com/apache/doris/pull/69123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](timezone)(branch-4.1) Normalize zero-offset time zones for ORC readers [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69123:
URL: https://github.com/apache/doris/pull/69123#issuecomment-6209321078
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](timezone)(branch-4.1) Normalize zero-offset time zones for ORC readers [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69123:
URL: https://github.com/apache/doris/pull/69123#issuecomment-6209321598
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](timezone)(branch-4.1) Normalize zero-offset time zones for ORC readers [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69123:
URL: https://github.com/apache/doris/pull/69123#issuecomment-6191165305
# FE Regression Coverage Report
Increment line coverage ` 22.22% (2/9)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69123_30c3d65a544cb15cdf0e4b9f04d604bbdf355985_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69123_30c3d65a544cb15cdf0e4b9f04d604bbdf355985_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org