[jira] [Commented] (NIFI-3926) Edit Template information

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313303#comment-16313303 ] 

ASF GitHub Bot commented on NIFI-3926:
--------------------------------------

Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2222#discussion_r159901869
  
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java ---
    @@ -2601,6 +2601,25 @@ public MutableVariableRegistry getVariableRegistry() {
             return variableRegistry;
         }
     
    +    @Override
    +    public void verifyCanUpdateTemplate(final String name, final String templateId) {
    +        // ensure the name is specified
    +        if (StringUtils.isBlank(name)) {
    +            throw new IllegalArgumentException("Template name cannot be blank.");
    +        }
    +
    +        for (final Template template : getTemplates()) {
    +            canUpdateTemplate(name, templateId, template.getDetails());
    +        }
    +    }
    +
    +    private void canUpdateTemplate(final String name, final String templateId, final TemplateDTO processGroupTemplate) {
    +        // prevent renaming to another template's name
    +        if (name.equals(processGroupTemplate.getName()) && !templateId.equals(processGroupTemplate.getId())) {
    --- End diff --
    
    Do we want the name comparison to be case-insensitive?


> Edit Template information
> -------------------------
>
>                 Key: NIFI-3926
>                 URL: https://issues.apache.org/jira/browse/NIFI-3926
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core UI
>    Affects Versions: 1.2.0
>            Reporter: Mark Bean
>            Assignee: Yuri
>            Priority: Minor
>
> Request the addition of an "edit" icon to each template in the list of NiFi Templates (Global Menu > Templates.) The edit would allow the user to modify the template name or description. Arguably, it may also allow the Process Group Id to be editable, but that seems far less likely to be desired.
> -Another option which is much more substantial and may require a separate ticket is to be able to edit the Template contents itself. That is, editing brings up the template on a fresh graph where components can be added, removed or modified.- Extracted to NIFI-4512.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)