[GitHub] [skywalking-java] xu1009 commented on a diff in pull request #541: Support jdk17 zgc

["xu1009 (via GitHub)" <gi...@apache.org>]

xu1009 commented on code in PR #541:
URL: https://github.com/apache/skywalking-java/pull/541#discussion_r1211519719


##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/gc/GCModule.java:
##########
@@ -88,4 +98,12 @@ public List<GC> getGCList() {
     protected abstract String getNewGCName();
 
     protected abstract String getNormalGCName();
+
+    protected String getCycleGcBeanName() {
+        return null;
+    }
+
+    protected String getPauseGcBeanName() {
+        return null;
+    }

Review Comment:
   the zgc gc count needs be collected from ZGC Cycles bean
   the zgc gc pause time needs be collected from  ZGC Pauses  bean
   
   so the two bean name should be in one gc module and then get  gc count and gc pause time from two bean  when collect 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org