You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/08/01 23:09:37 UTC

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala 

Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13983


Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................

IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
---
M docs/impala.ditamap
M docs/topics/impala_date.xml
2 files changed, 134 insertions(+), 51 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/13983/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 )

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13983/2/docs/topics/impala_date.xml
File docs/topics/impala_date.xml:

http://gerrit.cloudera.org:8080/#/c/13983/2/docs/topics/impala_date.xml@51
PS2, Line 51: ­
Not sure what this character is. Should be '-'. I saw other occassions, please check them as well.


http://gerrit.cloudera.org:8080/#/c/13983/2/docs/topics/impala_date.xml@147
PS2, Line 147: <codeph>NULL</codeph> is returned
Instead of NULL an error is returned:
select cast("2019-11-111" as date);
ERROR: UDF ERROR: String to Date parse failed. Invalid string val: "2019-11-111"



-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Aug 2019 08:52:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 )

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13983/2/docs/topics/impala_date.xml
File docs/topics/impala_date.xml:

http://gerrit.cloudera.org:8080/#/c/13983/2/docs/topics/impala_date.xml@51
PS2, Line 51: ­
> Not sure what this character is. Should be '-'. I saw other occassions, ple
Not sure how I typed this character. I tried fixing the ones I could catch.


http://gerrit.cloudera.org:8080/#/c/13983/2/docs/topics/impala_date.xml@147
PS2, Line 147: <codeph>NULL</codeph> is returned
> Instead of NULL an error is returned:
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Aug 2019 18:36:39 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 )

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................


Patch Set 3: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/432/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Aug 2019 18:50:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13983 )

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................

IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Reviewed-on: http://gerrit.cloudera.org:8080/13983
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Attila Jeges <at...@cloudera.com>
---
M docs/impala.ditamap
M docs/topics/impala_date.xml
M docs/topics/impala_literals.xml
3 files changed, 329 insertions(+), 189 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Attila Jeges: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13983

to look at the new patch set (#2).

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................

IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
---
M docs/impala.ditamap
M docs/topics/impala_date.xml
2 files changed, 137 insertions(+), 51 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/13983/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 )

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................


Patch Set 5:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/445/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 10 Aug 2019 00:17:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 )

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................


Patch Set 2: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/429/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 23:20:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 )

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................


Patch Set 4: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/437/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 15:11:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 )

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13983/3/docs/topics/impala_date.xml
File docs/topics/impala_date.xml:

http://gerrit.cloudera.org:8080/#/c/13983/3/docs/topics/impala_date.xml@79
PS3, Line 79: Hive 3.1 and lower versions 
> Hive 3.1 doesn't have this issue (as correctly stated in L84), only version
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 20:20:44 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 )

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................


Patch Set 4:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/437/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 14:46:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Attila Jeges, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13983

to look at the new patch set (#4).

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................

IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
---
M docs/impala.ditamap
M docs/topics/impala_date.xml
2 files changed, 153 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/13983/4
-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 )

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13983/3/docs/topics/impala_date.xml
File docs/topics/impala_date.xml:

http://gerrit.cloudera.org:8080/#/c/13983/3/docs/topics/impala_date.xml@79
PS3, Line 79: Hive 3.1 and lower versions 
> Done
Did you forget to upload that patch set? :)



-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 09:31:09 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 )

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................


Patch Set 4: Code-Review+1

I'm fine with the review. Let's wait for Attila Jeges to take another look.


-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Aug 2019 07:27:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Attila Jeges, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13983

to look at the new patch set (#3).

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................

IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
---
M docs/impala.ditamap
M docs/topics/impala_date.xml
2 files changed, 144 insertions(+), 51 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/13983/3
-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 )

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................


Patch Set 3:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/432/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Aug 2019 18:37:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 )

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/428/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 23:20:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 )

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Aug 2019 12:56:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 )

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/429/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 23:13:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 )

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13983/3/docs/topics/impala_date.xml
File docs/topics/impala_date.xml:

http://gerrit.cloudera.org:8080/#/c/13983/3/docs/topics/impala_date.xml@79
PS3, Line 79: Hive 3.1 and lower versions 
Hive 3.1 doesn't have this issue (as correctly stated in L84), only versions of Hive before 3.1.



-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 10:13:25 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 )

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/428/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 23:09:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Attila Jeges, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13983

to look at the new patch set (#5).

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................

IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
---
M docs/impala.ditamap
M docs/topics/impala_date.xml
M docs/topics/impala_literals.xml
3 files changed, 329 insertions(+), 189 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/13983/5
-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7374: [DOCS] Document the new DATE data type in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13983 )

Change subject: IMPALA-7374: [DOCS] Document the new DATE data type in Impala
......................................................................


Patch Set 5: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/445/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/13983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c28361c7f0d225708eaf4b955c6704520eaaa68
Gerrit-Change-Number: 13983
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 10 Aug 2019 00:25:59 +0000
Gerrit-HasComments: No